Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit persist mounts #560

Closed
flxo opened this issue Apr 8, 2022 · 2 comments
Closed

Revisit persist mounts #560

flxo opened this issue Apr 8, 2022 · 2 comments

Comments

@flxo
Copy link
Member

flxo commented Apr 8, 2022

There's no update command and persist mounts should be kept across container updates. The problem is that a container update has the sequence:

  • uninstall old version
  • install new version

The runtime cannot know whether a "new version" will be installed and therefore remove the persist dir. This might be not optional because cached data in this directly can be of value for "new version".

What are the options for quotas on persist mounts?

@flxo
Copy link
Member Author

flxo commented May 5, 2022

Thoughts:

Option 1: Extend api::model::Request::Uninstall with a flag that indicates whether to wipe the data or not. The runtime cannot know if there's a follow up install.

Options 2: Unpin uninstall - wipe the data dir if there's no other container with the same name (not version) present in any repository.

@flxo flxo added this to the 0.5.1 milestone Jul 8, 2022
@flxo flxo modified the milestones: 0.6.0, 0.7.0 Sep 2, 2022
@flxo
Copy link
Member Author

flxo commented Sep 2, 2022

Fixed by #662

@flxo flxo closed this as completed Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant