Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ab2p.common.css causes breakage on some sites #17

Closed
wmyrda opened this issue Jul 4, 2018 · 1 comment
Closed

ab2p.common.css causes breakage on some sites #17

wmyrda opened this issue Jul 4, 2018 · 1 comment

Comments

@wmyrda
Copy link

wmyrda commented Jul 4, 2018

When sites are visited privoxy is sending to browser info to ask webserver for both $host.css and ab2p.common.css like in example below

192.168.101.10 - - [04/Jul/2018:10:27:31 +0200] "GET /www.wprost.pl/ab2p.css HTTP/1.1" 200 12023
192.168.101.10 - - [04/Jul/2018:10:27:31 +0200] "GET /ab2p.common.css HTTP/1.1" 200 202974
192.168.101.10 - - [04/Jul/2018:10:27:33 +0200] "GET /www.wprost.pl/ab2p.css HTTP/1.1" 200 12023
192.168.101.10 - - [04/Jul/2018:10:27:33 +0200] "GET /ab2p.common.css HTTP/1.1" 200 202974
192.168.101.10 - - [04/Jul/2018:10:27:37 +0200] "GET /emisja.contentstream.pl/ab2p.css HTTP/1.1" 200 11937

Problem is than common.css contains all the element hidding entries from all the rulesets which for some sites causes problem as it is blocking more than it should. In this particular example common file has .cookiespopup which pl/wprost/www/ab2p.css does not have as it actually should not hence no ruleset said it should. Unintended effect is that causes whole website to completely disappear in the browser.

Ideal situation would be that browser asks for ab2p.common.css only if $host.css does not exist. Could that be acomplished by adblock2privoxy, privoxy or the webserver?

@essandess
Copy link
Owner

The CSS ab2p.common.css is used for hiding rules common to all domains; therefore, it should always be loaded. This is an issue with inconsistent rule sets, not the rule converter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants