-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adblock2privoxy compilation fail with GHC 8.4.3 #25
Comments
After I cloned this repo, I upgraded it to compile with resolver This was kind of a pain and required both some code refactoring and help from the Haskell community. I never did get it to compile with one of the ghc resolvers. Is there a reason you wish to use a different resolver? I’d recommend a “if it’s not broken don’t fix it” approach, unless indeed something is broken. |
Building the package Gentoo system I use has nice way of providing installation scripts (portage) which are called ebuilds. They inherit additional scripts to do the magic for given group of packages and in this case it is haskell-cabal. Hence it does its job right for 100s of packages I did not even look what exactly it did and what resolver it used to install package hence everything went smooth with installation script for adblock2privoxy I created. |
Patch for this issue is ready and tested. Fortunately only one instance of one file was affected.
|
Per #26, I'm going to try to address this now. I'll need your help. Rather than go to the trouble of creating a new branch, I'll use the existing one and show you the diffs, unless this becomes too burdensome. Here's what I've done:
First error look like below. Keep adding stuff to
A few things are clearly wrong here. Having to add all those I'm not sure which issue to tackle. Any insight based on your experience? |
Running
|
Using Gentoo overlay specified above which is work toward getting GHC 8.4.3 mainstreamed I did not need to update any libraries manually as during upgrade they all were rebuild by the updater. Some of them actually several times.
Haskell libs I have now are in following versions
|
Before I start mucking around with code or module versions, I’d like to understand why |
@essandess to use GHC 8.4.3 you need to switch to LTS-12, in qrilka@042ac83 I've fixed the code and |
@qrilka Wow thank you for the prompt help! I can copy your diffs easily enough. If you don't mind, I'd appreciate some insight into what we're changing, as @wmyrda is trying to create an ebuild with cabal as well. The errors above occur when I set:
|
@essandess I might have not it clearly enough, but my ebuild for Gentoo works and builds just fine using cabal. As you see in the end it said Some guidelines are here . However I am not sure if this should be updated to say >lts-12 hence it should be fine to build adblok2privoxy with older stack as well as patch does not delete any older code just adds a bit for new version. |
answering your questions @essandess
|
Adblock2privoxy fails to compile with GHC 8.4.3. Please take a look would fixing it be possible.
The text was updated successfully, but these errors were encountered: