Add periodic tracking and periodic validation for payment pointers #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vezwork
force-pushed
the
repeatedly_check_payment_pointer
branch
from
04c71c8
to
e17af7f
Compare
sharon-wang
changed the title
sharon-wang
reviewed
Nov 20, 2020
sharon-wang
reviewed
Nov 20, 2020
sharon-wang
reviewed
Nov 20, 2020
sharon-wang
reviewed
Nov 20, 2020
sharon-wang
reviewed
Nov 20, 2020
sharon-wang
reviewed
Nov 20, 2020
sharon-wang
reviewed
Nov 20, 2020
vezwork
force-pushed
the
repeatedly_check_payment_pointer
branch
from
e17af7f
to
a2db1fa
Compare
sharon-wang
reviewed
Nov 20, 2020
sharon-wang
reviewed
Nov 20, 2020
sharon-wang
reviewed
Nov 20, 2020
sharon-wang
reviewed
Nov 20, 2020
sharon-wang
reviewed
Nov 20, 2020
sharon-wang
reviewed
Nov 20, 2020
sharon-wang
reviewed
Nov 20, 2020
sharon-wang
reviewed
Nov 20, 2020
sharon-wang
reviewed
Nov 20, 2020
sharon-wang
reviewed
Nov 20, 2020
sharon-wang
reviewed
Nov 20, 2020
sharon-wang
reviewed
Nov 20, 2020
sharon-wang
reviewed
Nov 20, 2020
sharon-wang
reviewed
Nov 20, 2020
sharon-wang
reviewed
Nov 20, 2020
sharon-wang
reviewed
Nov 20, 2020
vezwork
force-pushed
the
repeatedly_check_payment_pointer
branch
from
a2db1fa
to
12545f5
Compare
sharon-wang
reviewed
Nov 20, 2020
sharon-wang
reviewed
Nov 20, 2020
sharon-wang
reviewed
Nov 20, 2020
vezwork
force-pushed
the
repeatedly_check_payment_pointer
branch
from
12545f5
to
0dcfd2e
Compare
sharon-wang
reviewed
Nov 20, 2020
sharon-wang
reviewed
Nov 20, 2020
sharon-wang
reviewed
Nov 20, 2020
sharon-wang
reviewed
Nov 20, 2020
sharon-wang
reviewed
Nov 20, 2020
sharon-wang
reviewed
Nov 20, 2020
vezwork
force-pushed
the
repeatedly_check_payment_pointer
branch
from
0dcfd2e
to
ed8bb39
Compare
sharon-wang
reviewed
Nov 20, 2020
vezwork
force-pushed
the
repeatedly_check_payment_pointer
branch
from
ed8bb39
to
646f7ef
Compare
|
Tested these changes to see if #76 would be resolved, but it's still reproducible. |
sharon-wang
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #17
I expect that this PR also fixes (#76), but that needs to be verified.Summary of Changes
setintervalwhich repeatedly checks if there is a new payment pointer on the current page.visibilitychangewhich updates the browser extension icon to the correct state when switching between tabs.validationTimestampfield to theAkitaPaymentPointerDataclass to facilitate verifying if a payment pointer was validated recently.Explanation of Added Features
Tracking and validating payment pointer if it changes on the current page
If a new payment pointer is encountered on the page and it has not been validated recently then it will be validated. If the validation is successful or if the payment pointer was already validated recently, the browser extension icon is set to the monetized state, otherwise it is set to the un-monetized state.
Setting extension icon correctly when switching between tabs
When switching between tabs, the payment pointer on the new tab is validated if it has not been validated recently. If the validation is successful or if the payment pointer was already validated recently, the browser extension icon is set to the monetized state, otherwise it is set to the un-monetized state.
Also note that payment pointers are no longer stored in browser storage if they fail validation.