Explicitly set CORS in http request and clean up extra whitespace #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sharon-wang <sharon-wang-cpsc@outlook.com>
Signed-off-by: sharon-wang <sharon-wang-cpsc@outlook.com>
vezwork
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #60
When using cors (Cross-Origin Resource Sharing), mixed content is blocked. This means that any content retrieved from HTTP (instead of HTTPS) will be blocked when working in an HTTPS context. Since we expect endpoints to resolve to an HTTPS url, we do not want to permit content loaded from HTTP. It is part of the SPSP Endpoint specification that HTTPS is required.
As such, we now explicitly include
mode: 'cors'in our http request to indicate this setting is needed, even though it is the default setting if left unspecified.