Use namespaced sigc::bind due to clash with std::bind

[vixus0]

This fixes some issues people have been having with compiling on systems where std::bind is declared. It also fixes the sigc++ trackable imports for the latest version of sigc++.

[essej]

Thanks, I'll merge that in soon!

Jesse

On Saturday, June 4, 2016, Anshul Sirur notifications@github.com wrote:

This fixes some issues people have been having with compiling on systems
where std::bind is declared. It also fixes the sigc++ trackable imports for

the latest version of sigc++.

You can view, comment on, or merge this pull request online at:

#6
Commit Summary

• Use namespaced sigc::bind due to clash with std::bind

File Changes

• M src/control_osc.hpp
  https://github.com/essej/sooperlooper/pull/6/files#diff-0 (2)
• M src/engine.cpp
  https://github.com/essej/sooperlooper/pull/6/files#diff-1 (2)
• M src/gui/app_frame.hpp
  https://github.com/essej/sooperlooper/pull/6/files#diff-2 (2)
• M src/gui/config_panel.hpp
  https://github.com/essej/sooperlooper/pull/6/files#diff-3 (2)
• M src/gui/keys_panel.hpp
  https://github.com/essej/sooperlooper/pull/6/files#diff-4 (2)
• M src/gui/latency_panel.cpp
  https://github.com/essej/sooperlooper/pull/6/files#diff-5 (4)
• M src/gui/latency_panel.hpp
  https://github.com/essej/sooperlooper/pull/6/files#diff-6 (2)
• M src/gui/looper_panel.cpp
  https://github.com/essej/sooperlooper/pull/6/files#diff-7 (182)
• M src/gui/main_panel.cpp
  https://github.com/essej/sooperlooper/pull/6/files#diff-8 (150)
• M src/gui/main_panel.hpp
  https://github.com/essej/sooperlooper/pull/6/files#diff-9 (2)
• M src/gui/midi_bind_panel.hpp
  https://github.com/essej/sooperlooper/pull/6/files#diff-10 (2)
• M src/gui/prefs_dialog.hpp
  https://github.com/essej/sooperlooper/pull/6/files#diff-11 (2)

Patch Links:

• https://github.com/essej/sooperlooper/pull/6.patch
• https://github.com/essej/sooperlooper/pull/6.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#6, or mute the thread
https://github.com/notifications/unsubscribe/ABmgVJx4jmnFZRG-HjbpCrU2Xfht3qeXks5qIipjgaJpZM4IuQm5
.

[virtualtam]

Hi @essej & @vixus0 !

This contribution originated from discussions on the corresponding Archlinux User Repository (AUR) package - https://aur.archlinux.org/packages/sooperlooper/

VirtualTam commented on 2016-04-13 21:11 (edited on 2016-04-13 21:11 by VirtualTam)

I've forked [1] SooperLooper's Git repository and experimented with Travis CI [2](Ubuntu 14.04 build container) and face similar build issues - errors with libsigc++ adaptors/functors [3].
This is a bit strange given Ubuntu's libsigc++ version is quite older (2.2.10) [4].
A similar bug has also been raised by the Debian Reproducible Build automation platform [5].
I'll try to build SooperLooper against older Arch packages (gcc/g++, libsigc++ 2.6.x), any help in root-causing the issue is appreciated ;-)

[1] https://github.com/virtualtam/sooperlooper
[2] https://travis-ci.org/virtualtam/sooperlooper/builds
[3] https://fossies.org/linux/misc/libsigc++-2.8.0.tar.gz/libsigc++-2.8.0/ChangeLog
[4] http://packages.ubuntu.com/trusty/libsigc++-2.0-0c2a
[5] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=819790

@vixus0 could you please:

• split this contribution over two commits (one per Arch patch)
• add credit for the author of the first patch (0001-trackable.patch) - https://aur.archlinux.org/account/sahquievaedoajie
• maybe add link to the corresponding libsigc++ 's changelog entries

@essej with this patch included, SooperLooper builds fine under:

• ArchLinux
• Ubuntu 14.04 (via Travis CI - https://travis-ci.org/virtualtam/sooperlooper/builds/135958235 )

[vixus0]

@virtualtam sure -- should that be two PRs or two commits?

Edit: Sorry, just read that properly...

[virtualtam]

Both patches being related to breaking API changes from libsigc++, it's fine to group them within the same PR :)

[vixus0]

Done :)

[virtualtam]

Thanks!

[magnetophon]

@essej Any news on this?

For what it's worth, I tested the PR on NixOS, and it solves the build problem there too.

[essej]

Sorry about the delay, merged it in!

[virtualtam]

Thanks @essej ;-)

[shreeswifty]

is there a place i may fins a SooperLooper.so for Raspberry Pi?