make --exclude also exclude packages from results #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
est31
approved these changes
Jan 12, 2023
Specifically, if a package A depends on B and that dependency is unused, --exclude A will omit it from the results, but --exclude B will not.
|
Hmmm that CI failure seems to also reproduce before this PR. Any advice? |
|
@danhhz yeah it's not your fault. It's due to the cargo update, I need to investigate it more. |
|
Okay, gotcha. Thanks so much! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, if a package A depends on B and that dependency is unused, --exclude A will omit it from the results, but --exclude B will not.
Closes #146