Skip to content

Commit

Permalink
remove unrelated changes
Browse files Browse the repository at this point in the history
  • Loading branch information
BEvgeniyS committed Jan 30, 2023
1 parent 8d12572 commit b58f5ae
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions docs/getting-started.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,10 @@ target:
role: arn:aws:iam::123456789012:role/roleName
```
!!! note
Make sure that target role has proper trust permissions that allow to assume it cross-account
Make sure that target role has proper trust permissions that allow to assume it cross-account

!!! note
In order te be able to pull images from outside accounts, you will have to apply proper access policy
In order te be able to pull images from outside accounts, you will have to apply proper access policy


#### Access policy
Expand Down
3 changes: 2 additions & 1 deletion docs/metrics.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,6 @@ k8s_image_swapper_main_errors | Number of errors
k8s_image_swapper_cache_hits | Number of registry cache hits
k8s_image_swapper_cache_misses | Number of registry cache misses
k8s_image_swapper_cache_filtered | Number of registry cache filtered out
k8s_image_swapper_cache_images_copied | Number of images copied
k8s_image_swapper_cache_image_copy_duration_seconds | Image copy duration in seconds
k8s_image_swapper_cache_repos_create_requests | Number of repositories create attempts
k8s_image_swapper_cache_repos_created | Number of repositories created
1 change: 0 additions & 1 deletion pkg/webhook/image_swapper.go
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,6 @@ func (p *ImageSwapper) Mutate(ctx context.Context, ar *kwhmodel.AdmissionReview,
case types.ImageSwapPolicyAlways:
log.Ctx(lctx).Debug().Str("image", targetImage).Msg("set new container image")
containers[i].Image = targetImage
metrics.IncrementCacheHits(ar.Namespace, reference.Domain(srcRef.DockerReference()), repoName)
case types.ImageSwapPolicyExists:
if p.registryClient.ImageExists(lctx, targetImage) {
log.Ctx(lctx).Debug().Str("image", targetImage).Msg("set new container image")
Expand Down

0 comments on commit b58f5ae

Please sign in to comment.