cleanup

estahn · Jan 25, 2023 · c57acaf · c57acaf
1 parent 2adeb76
commit c57acaf
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/pkg/metrics/metrics.go b/pkg/metrics/metrics.go
@@ -100,6 +100,7 @@ var (
 	)
 	reposCreated = prometheus.NewCounterVec(
 		prometheus.CounterOpts{
+			Namespace: "k8s_image_swapper",
 			Subsystem: "cache",
 			Name:      "repos_created",
 			Help:      "Number of repositories created",

diff --git a/pkg/webhook/image_swapper.go b/pkg/webhook/image_swapper.go
@@ -211,7 +211,13 @@ func (p *ImageSwapper) Mutate(ctx context.Context, ar *kwhmodel.AdmissionReview,
 			targetImage := p.targetName(srcRef)
 
 			copyFn := func() {
+				// Avoid unnecessary copying by ending early. For images such as :latest we adhere to the
+				// image pull policy.
+				if p.registryClient.ImageExists(targetImage) && container.ImagePullPolicy != corev1.PullAlways {
+					return
+				}
 
+				// Create repository
 				createRepoName := reference.TrimNamed(srcRef.DockerReference()).String()
 				log.Ctx(lctx).Debug().Str("repository", createRepoName).Msg("create repository")
 				if err := p.registryClient.CreateRepository(createRepoName); err != nil {