Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: Upgrade libraries, changing interfaces and introduci… #19

Merged
merged 2 commits into from Oct 26, 2018

Conversation

estahn
Copy link
Owner

@estahn estahn commented Oct 26, 2018

…ng schema storage

  • justinrainbow/json-schema has been upgraded to the latest version (5.x)
  • Interface for assertJsonMatchesSchema has changed from assertJsonMatchesSchema($schema, $content) to assertJsonMatchesSchema($content, $schema = null)
  • Support for schema storage within traits (see README.md)

…ng schema storage

* `justinrainbow/json-schema` has been upgraded to the latest version (5.x)
* Interface for `assertJsonMatchesSchema` has changed from `assertJsonMatchesSchema($schema, $content)` to `assertJsonMatchesSchema($content, $schema = null)`
* Support for schema storage within traits (see README.md)
@codecov-io
Copy link

codecov-io commented Oct 26, 2018

Codecov Report

Merging #19 into master will decrease coverage by 2.32%.
The diff coverage is 93.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #19      +/-   ##
============================================
- Coverage       100%   97.67%   -2.33%     
- Complexity       11       16       +5     
============================================
  Files             2        2              
  Lines            35       43       +8     
============================================
+ Hits             35       42       +7     
- Misses            0        1       +1
Impacted Files Coverage Δ Complexity Δ
src/Extension/Symfony.php 100% <100%> (ø) 4 <0> (ø) ⬇️
src/Assert.php 96.55% <92.85%> (-3.45%) 12 <6> (+5)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f66884...820010f. Read the comment docs.

@estahn
Copy link
Owner Author

estahn commented Oct 26, 2018

This will fix #18

@estahn estahn merged commit e75e20d into master Oct 26, 2018
@estahn estahn deleted the schema-storage branch October 26, 2018 06:26
@estahn
Copy link
Owner Author

estahn commented Oct 26, 2018

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants