Improve flaky endpoint handling #205
Conversation
norman
force-pushed
the
improve-flaky-endpoint-handling
branch
3 times, most recently
from
d6c52e3
to
775b700
Compare
| @client.options[:recoverable_error_wait_secs] = 3.14 | ||
| @client.expects(:sleep).with(3.14).times(3) | ||
| @client.stubs(:find_every).raises(Rets::MiscellaneousSearchError.new(0, 'Foo')) | ||
| @client.find(:all, :foo => :bar) rescue nil |
There was a problem hiding this comment.
I feel a little funny about this rescue nil. I assume this line raises an exception, can we wrap this line in a expect {...}.to raise_error instead?
There was a problem hiding this comment.
My thoughts here were that asserting on the raised error might make it less apparent that the test was about the sleep rather than the exception being raised.
There was a problem hiding this comment.
makes sense... I have a long cultivated aversion to rescue nil, but I suppose it makes sense in this context.
| @@ -105,9 +105,11 @@ def find_with_given_retry(retries, opts) | |||
| end | |||
|
|
|||
| def handle_find_failure(retries, opts, e) | |||
| if retries < opts.fetch(:max_retries, 3) | |||
| max_retries = opts.fetch(:max_retries, options.fetch(:max_retries, 3)) | |||
There was a problem hiding this comment.
opts and options both being used here is a little hard to read, might be worth changing the name of the local variable (local_options?), but I'm not too worried about it.
There was a problem hiding this comment.
What do you think of c43b478?
|
Looks good! |
I recently needed to work around some issues with a flaky RETS server that would randomly time out some requests. The responses would come back with HTTP 200 but with an error message in the response body, and happened only sporadically.
These modifications are perhaps a bit short on aesthetics and long on pragmatism but I think would help in circumstances that are likely to appear at times in applications that use this library with lot of different RETS endpoints.
Summary of changes:
clientblock of a YML config file so that it can be applied to all requests.