Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Put back React Native #1477

Closed
steida opened this issue Feb 23, 2018 · 12 comments
Closed

Put back React Native #1477

steida opened this issue Feb 23, 2018 · 12 comments

Comments

@steida
Copy link
Contributor

steida commented Feb 23, 2018

  • Probably in /screens dir
  • Rethink (again) universal UI library. Common base components I have, or reactxp, or react-native-web? I don't know yet. What is the most pragmatic? Update: react-native-web.
@steida
Copy link
Contributor Author

steida commented Mar 9, 2018

vercel/next.js#3018

@steida
Copy link
Contributor Author

steida commented Mar 10, 2018

Hmm, it seems we can not have one shared / unversal package.json anymore. React Native Flow settings etc. So, it seems, we have to have two separated projects.

@steida
Copy link
Contributor Author

steida commented Mar 10, 2018

Hmm, also React Native seems to be unable to import file outside of /native directory.
screen shot 2018-03-10 at 02 42 51

screen shot 2018-03-10 at 02 45 17

@steida
Copy link
Contributor Author

steida commented Mar 10, 2018

So I don't know how to share code across Next.js and React Native without two package.json files and some symlinks. One package.json file would be ideal, but it seems to be impossible as well.

Maybe, some kind of private NPM could work. Maybe.

@steida
Copy link
Contributor Author

steida commented Mar 10, 2018

@msand
Copy link

msand commented Mar 10, 2018

How about a lerna mono repo? Separate package.json files might sometimes be useful e.g, if independent parts of native/web need different version of the same package. Or if someone only works on parts of the project etc.

@msand
Copy link

msand commented Mar 10, 2018

React Native should be able to import external components. I had a working proof-of-concept based on the old Este and RNWeb in may last year: msand@9ad2869

@msand
Copy link

msand commented Mar 10, 2018

I just remembered, I used a universal project with Next.js and React Native to compare and fix svg spec conformance of react-native-svg. I just updated the versions and made sure it still starts:
https://github.com/msand/newproject

screen shot 2018-03-10 at 14 34 29

@steida
Copy link
Contributor Author

steida commented Mar 11, 2018

@msand Thank you. But it's without working .flowconfig.

@msand
Copy link

msand commented Mar 11, 2018

Ah yeah, that's probably true, didn't test that.

@steida
Copy link
Contributor Author

steida commented Mar 12, 2018

I fixed it. Thank you for your help.

@msand
Copy link

msand commented Mar 12, 2018

Great! Looking forward to the Next (pun intended) version 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants