Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Separate Client and Server Actions? #50

Closed
ronag opened this issue Mar 11, 2015 · 5 comments
Closed

Separate Client and Server Actions? #50

ronag opened this issue Mar 11, 2015 · 5 comments

Comments

@ronag
Copy link

ronag commented Mar 11, 2015

No description provided.

@steida
Copy link
Contributor

steida commented Mar 11, 2015

Actually, not needed ;-) facebookarchive/flux#172

@steida steida closed this as completed Mar 11, 2015
@ronag
Copy link
Author

ronag commented Mar 11, 2015

No I mean. The way it is now we can't have "media client" actions and "media server" actions in separate files which is a requirement for avoiding circular imports.

i.e. a common pattern is:

user client action -> webapi -> user server action

e.g.

// Client Actions

export function createUser(name:String) {
   WebApi.createUser(name)
   dispatch(createUser, name)
}

// WebApi

export function createUser(name:String) {
  // ...
}

// Server Actions

export function createdUser(id:String) {
  dispatch(createdUser, id)
}

@steida
Copy link
Contributor

steida commented Mar 12, 2015

PR please.

@steida steida reopened this Mar 12, 2015
@ronag
Copy link
Author

ronag commented Mar 12, 2015

I don't have any good suggestion for solution. Just pointing out a problem.

@steida steida closed this as completed Mar 12, 2015
@steida steida reopened this Mar 13, 2015
@steida
Copy link
Contributor

steida commented Mar 13, 2015

I am not aware of this issue yet, maybe it's not problem with ES6 modules. Let's wait.

@steida steida closed this as completed Mar 16, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants