Removed special FindBlockArgumentAssignmet visitor

estebanlm · Dec 10, 2019 · 86dbff1 · 86dbff1
1 parent 918098d
commit 86dbff1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 78 deletions.
diff --git a/src/AST-Core/RBFindBlockArgumentAssignment.class.st b/src/AST-Core/RBFindBlockArgumentAssignment.class.st
diff --git a/src/GeneralRules/RBAssignmentOnBlockArgumentRule.class.st b/src/GeneralRules/RBAssignmentOnBlockArgumentRule.class.st
@@ -1,12 +1,14 @@
 "
-Check for assignments on block arguments.
+Check for assignments on method and block arguments.
 For example:
 
 [:x :y|
 	x:= x+y.
 	]
 
 The block argument ""x"" should not be written. This is considered bad style. And some compiler may reject that code.
+
+Same for method arguments, you should not write those either.
 "
 Class {
 	#name : #RBAssignmentOnBlockArgumentRule,
@@ -29,7 +31,8 @@ RBAssignmentOnBlockArgumentRule class >> uniqueIdentifierName [
 { #category : #running }
 RBAssignmentOnBlockArgumentRule >> check: aMethod forCritiquesDo: aCriticBlock [
 	| problemAssignments|
-	problemAssignments := RBFindBlockArgumentAssignment collectAssignments: aMethod ast.
+	problemAssignments := aMethod ast assignmentNodes 
+		select: [ :assignment | assignment variable isArg].
 
 	problemAssignments do: [ :assignment |
 			aCriticBlock cull: (ReTrivialCritique