Skip to content

Commit

Permalink
Fix pharo-project#4817. Do not log MC save anymore.
Browse files Browse the repository at this point in the history
  • Loading branch information
tinchodias committed Oct 14, 2019
1 parent 84b1e2a commit cecd6d6
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 33 deletions.
15 changes: 0 additions & 15 deletions src/Epicea-Tests/EpEventIntegrationTest.class.st
Expand Up @@ -31,18 +31,3 @@ EpEventIntegrationTest >> mockVersionInfo [
author: ''
ancestors: #()
]

{ #category : #tests }
EpEventIntegrationTest >> testMCVersionSaved [
| version repository |
self skipOnPharoCITestingEnvironment.
self flag: #pharoFixMe. "Don't understand why it fails in non-interactive mode (in Jenkins)"
version := self mockVersion.
repository := MCDictionaryRepository new.

self assert: (self countLogEventsWith: EpMonticelloVersionSave) equals: 0.

repository storeVersion: version.

self assert: (self countLogEventsWith: EpMonticelloVersionSave) equals: 1
]
11 changes: 0 additions & 11 deletions src/Epicea/EpMonitor.class.st
Expand Up @@ -502,16 +502,6 @@ EpMonitor >> methodRemoved: aMethodRemovedAnnouncement [
yourself))]
]

{ #category : #'announcement handling' }
EpMonitor >> monticelloVersionSaved: aMCVersionSaved [

self handleAnyErrorDuring: [
aMCVersionSaved repository description = 'cache' ifFalse: [
self addEvent: aMCVersionSaved asEpiceaEvent ].
"Note: Tried to encapsulate this check in the hierarchy of MCRepository
but caused troubles to iceberg, since it has a repository that's not in such hierarchy." ]
]

{ #category : #'announcement handling' }
EpMonitor >> protocolAdded: aProtocolAdded [

Expand Down Expand Up @@ -595,7 +585,6 @@ EpMonitor >> subscribeToSystemAnnouncer [
ClassRenamed -> #classRenamed:.
ClassCommented -> #classCommented:.
MethodRecategorized -> #methodRecategorized:.
MCVersionSaved -> #monticelloVersionSaved:.
SnapshotDone -> #snapshotDone:.

} do: [ :pair |
Expand Down
7 changes: 0 additions & 7 deletions src/Epicea/MCVersionSaved.extension.st

This file was deleted.

0 comments on commit cecd6d6

Please sign in to comment.