Enable use of credential helpers #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses GetAuthConfig from github.com/docker/cli, which embeds logic for handling credential helpers.
|
Thanks for this! I haven't been focused much on this v1 codebase as I've almost completed a "rework" for a v2 that supports cred helpers natively by using oras + containerd as the registry auth/transaction layer: https://github.com/estesp/manifest-tool/tree/v2-rework That said, it won't hurt to have this in the v1 codebase as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses GetAuthConfig from github.com/docker/cli, which embeds logic
for handling credential helpers.
I was surprised that manfiest-tool didn't work with credential helpers when I tried it! :)
You may want to clean this up a bit more by just reading the config file once here and passing it around, but I wanted to keep the diff small to avoid breaking anything.
Fixes #92