Fix segfault and add (optional) variant in image config #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a YAML file that doesn't include `platform:` objects at all, the following is the result: ``` panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x8aa679] goroutine 1 [running]: github.com/estesp/manifest-tool/pkg/registry.resolvePlatform(0xc000568840, 0x34, 0xc000578b90, 0x47, 0x20f, 0x0, 0x0, 0x0, 0x0, 0x0, ...) /go/src/github.com/estesp/manifest-tool/pkg/registry/push.go:126 +0xb9 github.com/estesp/manifest-tool/pkg/registry.PushManifestList(0x0, 0x0, 0x0, 0x0, 0xc00045a168, 0x15, 0x0, 0x0, 0x0, 0xc00040aa80, ...) /go/src/github.com/estesp/manifest-tool/pkg/registry/push.go:92 +0xdfb main.glob..func2(0xc00044c420) /go/src/github.com/estesp/manifest-tool/cmd/manifest-tool/push.go:55 +0x3cf github.com/urfave/cli.HandleAction(0x98c520, 0xa7a7b8, 0xc00044c420, 0xc00044c420, 0x0) /go/src/github.com/estesp/manifest-tool/vendor/github.com/urfave/cli/app.go:525 +0x59 github.com/urfave/cli.Command.Run(0xa503af, 0x9, 0x0, 0x0, 0x0, 0x0, 0x0, 0xa68e68, 0x32, 0x0, ...) /go/src/github.com/estesp/manifest-tool/vendor/github.com/urfave/cli/command.go:174 +0x579 github.com/urfave/cli.(*App).RunAsSubcommand(0xc000472380, 0xc00044c160, 0x0, 0x0) /go/src/github.com/estesp/manifest-tool/vendor/github.com/urfave/cli/app.go:404 +0x914 github.com/urfave/cli.Command.startApp(0xa4c181, 0x4, 0x0, 0x0, 0x0, 0x0, 0x0, 0xa6de45, 0x4e, 0x0, ...) /go/src/github.com/estesp/manifest-tool/vendor/github.com/urfave/cli/command.go:373 +0x7ff github.com/urfave/cli.Command.Run(0xa4c181, 0x4, 0x0, 0x0, 0x0, 0x0, 0x0, 0xa6de45, 0x4e, 0x0, ...) /go/src/github.com/estesp/manifest-tool/vendor/github.com/urfave/cli/command.go:102 +0xa14 github.com/urfave/cli.(*App).Run(0xc0004721c0, 0xc000020080, 0x4, 0x4, 0x0, 0x0) /go/src/github.com/estesp/manifest-tool/vendor/github.com/urfave/cli/app.go:276 +0x7e8 main.runApplication(0xc000000180, 0xc00025ff78) /go/src/github.com/estesp/manifest-tool/cmd/manifest-tool/main.go:75 +0x605 main.main() /go/src/github.com/estesp/manifest-tool/cmd/manifest-tool/main.go:20 +0x26 ``` Signed-off-by: Tianon Gravi <admwiggin@gmail.com>
|
(To be clear, I don't do this often, but when I do... no, I just happened to have a test YAML lying around that I wanted/needed to test a build against and it happened to not specify |
|
Thanks @tianon ; good find, even if unexpected :) |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a YAML file that doesn't include
platform:objects at all, the following is the result: