Final audit before 1.0

[estk]

Last task before release

[estk]

@gadunga wanna pair on this?

[gadunga]

Sure, I can take a look. I'd like to try and get #21 in as well. What do you think?

[estk]

Ya that sounds good.

[gadunga]

Made a comment and opened an MR to remove log4rs::FormatError::XmlFeatureFlagRequired.

[rakshith-ravi]

Just a suggestion, but can we remove all Box<dyn Trait> instances and make them as generic parameters instead? Boxs get allocated in the heap and heap access is almost always slower than stack access. So it would significantly improve performance as well as help clean up the code (now that we don't have to do all those Box::news any more). Generic parameters make it a lot more easier to have ownership of the values as well.

[estk]

@rakshith-ravi I take your point, and I've thought about it myself. I worry that with such a large change to the config api we would split the ecosystem of log4rs users and plugins.

[rakshith-ravi]

Well my thinking was that before we hit 1.0 is the best chance for us to make any breaking changes. Once we hit stable 1.0, it'll become difficult to undo these and we wouldn't want it to become a performance bottleneck because of such a silly thing, which we could've changed

[estk]

@rakshith-ravi I spent some time investigating this, there's just no way to do it since we need to hold heterogeneous collections of Append and Encode impling types. The reason we cant just hard code these is because the api is extensible and we dont know all possible Append etc types up front.

[rakshith-ravi]

Ahh, I suppose that makes sense. Generics don't really work out when we need a collection of multiple items of different size. Looks like Box is our only way to go. Thanks for considering it and attempting to fix it through :D