Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0 Release #154

Merged
merged 27 commits into from
Dec 16, 2020
Merged

1.0 Release #154

merged 27 commits into from
Dec 16, 2020

Conversation

estk
Copy link
Owner

@estk estk commented Apr 4, 2020

Closes #148

Downstream testing

We need to test how broken the log4rs ecosystem crates are after this release.

Api guidelines

  • Naming
  • Interop
  • Macros
  • Docs
  • Predictability
  • Flexability
  • Type Safety
  • Dependability
  • Debuggability
  • Future Proofing
  • Necessities

Final:

  • Audit docs
  • Merge color change PR#167
  • Update Changelog

@estk estk requested a review from gadunga April 4, 2020 18:28
@estk estk changed the title Devel 1.0 Release Apr 4, 2020
src/lib.rs Outdated Show resolved Hide resolved
@estk
Copy link
Owner Author

estk commented Apr 4, 2020

@calvinbrown085 Working on 1.0, was thinking you might like to help in the final audit.

@gadunga
Copy link
Collaborator

gadunga commented Apr 4, 2020

Adding a note here: We need to remove log4rs::FormatError::XmlFeatureFlagRequired

@gadunga
Copy link
Collaborator

gadunga commented Apr 5, 2020

So I looked at the docs, they seem ok. Or rather we didn't make them worse. So there's that. What kind of changes were you looking at doing for the config_parsing stuff?

@gadunga
Copy link
Collaborator

gadunga commented Apr 5, 2020

In the docs we have:

Loggers are also associated with a set of appenders. Appenders can be associated directly with a logger. In addition, the appenders of the logger's parent will be associated with the logger unless the logger has its additivity set to false. Log events sent to the logger that are not filtered out by the logger's maximum log level will be sent to all associated appenders.

However in code additivity not actually valid, it should be additive

@calvinbrown085
Copy link
Contributor

@estk 👋 I'll try to give this a look, thanks for the ping!

@estk
Copy link
Owner Author

estk commented Jul 22, 2020

@calvinbrown085 @gadunga would you build the docs locally and review? I'd like to do some final auditing before launching this bird.

IceSentry and others added 5 commits September 28, 2020 15:25
* WIP custom err handling

* Compiling

* Add an  method to the public api

* re-enable Debug
Co-authored-by: braindead <braindeaded@protonmail.com>
…186)

* pattern encoder: Set trace to default color, reset formatting after

* Fix formatting of last commit

* lol apparently rustfmt doesn't like commas? idk if this will work

* Set trace color to cyan
@estk estk merged commit d637eea into master Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Final audit before 1.0
6 participants