Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

escodegen embeds an old version of estraverse #83

Closed
jasvir opened this issue Jan 13, 2013 · 0 comments
Closed

escodegen embeds an old version of estraverse #83

jasvir opened this issue Jan 13, 2013 · 0 comments

Comments

@jasvir
Copy link

jasvir commented Jan 13, 2013

escodegen.js embeds a copy of estraverse (see https://github.com/Constellation/escodegen/blob/master/escodegen.js#L2027) - specifically one that does not benefit from bugfixes in estraverse (including the recent fix of ObjectExpressions by @michaelficarra.

It also exports the embedded traverse function which, depending on the order in which escodegen and estraverse are loaded, can clobber the fixed version.
Constellation added a commit that referenced this issue Jan 14, 2013
@Constellation
Merge pull request #84 from michaelficarra/GH-83
a692dd4 
fixes #83: use estraverse's `traverse` function instead of our own
@jsoverson jsoverson mentioned this issue Jan 23, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Constellation @jasvir