Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo: protc is not found #2

Merged
merged 1 commit into from
Sep 26, 2021
Merged

typo: protc is not found #2

merged 1 commit into from
Sep 26, 2021

Conversation

kawanet
Copy link
Contributor

@kawanet kawanet commented Sep 26, 2021

This PR is to fix a typo in a message in configure.

The WARNING sounds weak and looks not enough as protoc is required to build tkrzw-rpc from source, by the way.

@estraier estraier merged commit f4a4bbf into estraier:master Sep 26, 2021
@estraier
Copy link
Owner

Thanks for the fix.
I agree that WARNING sound weak. Stopping the configure on the spot is a feasible option.
The reason I do this currently is that stopping by one issue prevents us from listing up all issues at once.
And for some people, fixing the problem by editing Makefile manually is easier than setting proper environment variables for configure.
So, let us keep this structure until we find a better solution.

@estraier estraier mentioned this pull request Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants