Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use splice in on to avoid memory leak #1

Merged
merged 1 commit into from
Apr 4, 2019
Merged

Use splice in on to avoid memory leak #1

merged 1 commit into from
Apr 4, 2019

Conversation

mikehwagz
Copy link
Collaborator

Hey Eric, I've been admiring your work for a while now and I'm really enjoying this clever little library!

While reading the source, I think I caught a typo in the on method where slice was used instead of splice, so here's a tiny PR.

Cheers 🍻

@estrattonbailey
Copy link
Collaborator

@mikehwagz hey thanks! Nice catch :)

Appreciate the kind words as well, and same to you. Was just admiring choozy actually. Def gonna use that in the future! Also also, chatted with Mark at TakeShape a few weeks ago and p sure we should grab beers next time you're in NYC.

@estrattonbailey estrattonbailey merged commit ad5ead4 into selfawarestudio:master Apr 4, 2019
@mikehwagz
Copy link
Collaborator Author

of course, and thank you 🙏 glad you dig choozy!

oh hi mark! will def let you know when I'm in NYC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants