oauth: allow using templates in OAuth response template #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airbyte has recently introduced new fields to their OAuth response mappings, which need processing. In this case, we have AirTable which requires the `expires_in` field of response to be added to `now()` and rendered as an RFC3339 date to work. So I'm adding a condition here which allows response map to be rendered using a template instead of just jsonpointer. In hindsight, we can probably just get rid of jsonpointers here and use mustache templates for the responseMap since it can do the same job anyway. For now I'm keeping both.
mdibaiee
force-pushed
the
mahdi/template-response-map
branch
from
2ea0271
to
6f3a78f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
airbyte has recently introduced new fields to their OAuth response mappings, which need processing. In this case, we have AirTable which requires the
expires_infield of response to be added tonow()and rendered as an RFC3339 date to work. See here So I'm adding a condition here which allows response map to be rendered using a template instead of just jsonpointer.In hindsight, we can probably just get rid of jsonpointers here and use mustache templates for the responseMap since it can do the same job anyway. For now I'm keeping both.
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)
This change is