Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(es_extended/server/classes/player.lua): xPlayer.canCarryItem - Error handling - Item not found #563

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

OMikkel
Copy link
Contributor

@OMikkel OMikkel commented Oct 11, 2022

Recently came across a guy in my community who tried to use this function, but he got this error.
Error Image

Obviously, this is not that helpful and I would presume that it is not the first time someone passed an unknown item into this function and got this error.

Added a check to display a more precise error message

Copy link
Contributor

@Gittified Gittified left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Please take a look at #343 as well @OMikkel

@OMikkel OMikkel changed the title xPlayer.canCarryItem - Error handling - Item not found refactor(es_extended/server/classes/player.lua): xPlayer.canCarryItem - Error handling - Item not found Oct 13, 2022
@JackDUpModZ JackDUpModZ merged commit 0e1e473 into esx-framework:main Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants