fix(esx_lscustom): default wheels #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iSentrie
suggested changes
Nov 11, 2022
iSentrie
reviewed
Nov 11, 2022
| label = " " .. TranslateCap('by_default'), | ||
| modType = "modFrontWheels", | ||
| modNum = -1, | ||
| wheelType = -1 |
There was a problem hiding this comment.
set additional value
price = 1
or something
There was a problem hiding this comment.
Hi, thanks for the review.
I put the price to 1 like you said, but I'm thinking of maybe setting the default price in the config so anyone can just change it like the other wheels prices, what do you think?
There was a problem hiding this comment.
config is the proper way to do it too👍
There was a problem hiding this comment.
Ok it's pushed, i've set it to 2 by default since the other wheels are at 4+ price, thought 50% would be a good value but if you prefer 1 i change it in a sec
iSentrie
approved these changes
Nov 11, 2022
JackDUpModZ
approved these changes
Nov 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this fixes the default value for wheels.
Currently, if you change to custom wheel type you can never go back to the car default wheels.
Regards