refactor(es_extended): some core functions and small improvements #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add new table: Core.playersByIdentifier removed for loop from GetPlayerFromIdentifier.
it only stayed for backwards compatibility
small code format
format: Core.SavePlayer
if nui cursor is active, movement is disabled.
timeout functions moved to shared file and removed thread from client side
Rav3n95
approved these changes
Jan 24, 2023
…yers() with ESX.Players so performance is more optimal, because there is no for loop running in the background for ESX.GetExtendedPlayers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.