feat: Metadata #912

Rav3n95 · 2023-02-21T22:22:00Z

No description provided.

[core]/es_extended/server/main.lua

CsokiHUN

looks good

Gellipapa · 2023-02-22T09:17:18Z

Really cool, but a log system would be better than using prints, and if I have metadata then how can I update the value of a given key? So I don't want the whole table just one value of it, if I saw it right it allows to add table as metadata.

CsokiHUN · 2023-02-22T09:19:32Z

Really cool, but a log system would be better than using prints, and if I have metadata then how can I update the value of a given key? So I don't want the whole table just one value of it, if I saw it right it allows to add table as metadata.

xPlayer.setMeta('your_key', value)

So you are not updating the whole key, only the value for that key.

Gellipapa · 2023-02-22T09:25:45Z

What happens if I add table as value how do I update the value?
table_data = {bread = 200, water = 300}
key: table_data
value: {bread = 200, water = 300}
i would like the water to be only 400 the correct output would be: {bread = 200, water = 400}.

Rav3n95 · 2023-02-22T09:28:09Z

Then you get the index of the data, update it yourself, then send the updated table back. That's why I posted in Dev branch, if you have a idea how to fix this issue whit out using the getter first. Go for it :D

Gellipapa · 2023-02-22T09:30:02Z

Another feature, I want to retrieve a value from a table, how do I do that?

key: table_data
value {bread:200, water:300}

I'm only interested in the water value? How can I get it?

getMeta(table_data, "water") --> output: 300.

I think such an option could be in getter, of course it would only work for table.

CsokiHUN · 2023-02-22T09:31:25Z

What happens if I add table as value how do I update the value? table_data = {bread = 200, water = 300} key: table_data value: {bread = 200, water = 300} i would like the water to be only 400 the correct output would be: {bread = 200, water = 400}.

I understand what you are saying, but I don't think we can do it well. Because what if someone uses a non-string key at the table..
It's not that big of a problem if the whole table needs to be updated, because we're not going to store a lot of data here.

Rav3n95 · 2023-02-22T09:31:42Z

What if the stored value it's not a table?

CsokiHUN · 2023-02-22T09:32:24Z

If we include the option to retrieve the value of the key from the table, we are in the same place as if we had done it ourselves

Gellipapa · 2023-02-22T09:32:34Z

Then you get the index of the data, update it yourself, then send the updated table back. That's why I posted in Dev branch, if you have a idea how to fix this issue whit out using the getter first. Go for it :D

A possible solution, with an optional parameter, is to use only a table because you can update a not a table value.
For example: setMeta(table_data,'water', 400)

Gellipapa · 2023-02-22T09:34:08Z

If it is not a table you return the given key value.

Rav3n95 · 2023-02-22T09:35:59Z

Show me the code then :D

Gellipapa · 2023-02-22T09:36:36Z

If we include the option to retrieve the value of the key from the table, we are in the same place as if we had done it ourselves

It is better than always having to retrieve and index everything. Of course there is also an indexing in the background but it is in the background. It is more practical to have the option to return a specific value or the whole table.

These are just the features and ideas I threw in here :)

Rav3n95 · 2023-02-22T09:37:36Z

xPlayer.setMeta('bikes', {'20', '24', '26', '27.5', '28', '29'}) How about a not indexed table value?

CsokiHUN · 2023-02-22T09:55:31Z

xPlayer.setMeta('bikes', {'20', '24', '26', '27.5', '28', '29'}) How about a not indexed table value?

fun fact: you store the numbers as string 😂

Gellipapa · 2023-02-22T10:00:33Z

This is core logic. Need nil handler etc.

local function printTable( t )
 
    local printTable_cache = {}
 
    local function sub_printTable( t, indent )
 
        if ( printTable_cache[tostring(t)] ) then
            print( indent .. "*" .. tostring(t) )
        else
            printTable_cache[tostring(t)] = true
            if ( type( t ) == "table" ) then
                for pos,val in pairs( t ) do
                    if ( type(val) == "table" ) then
                        print( indent .. "[" .. pos .. "] => " .. tostring( t ).. " {" )
                        sub_printTable( val, indent .. string.rep( " ", string.len(pos)+8 ) )
                        print( indent .. string.rep( " ", string.len(pos)+6 ) .. "}" )
                    elseif ( type(val) == "string" ) then
                        print( indent .. "[" .. pos .. '] => "' .. val .. '"' )
                    else
                        print( indent .. "[" .. pos .. "] => " .. tostring(val) )
                    end
                end
            else
                print( indent..tostring(t) )
            end
        end
    end
 
    if ( type(t) == "table" ) then
        print( tostring(t) .. " {" )
        sub_printTable( t, "  " )
        print( "}" )
    else
        sub_printTable( t, "  " )
    end
end


local metadata = {
  ["table_data"] = {bread =  200, water =  300}
}

function getMeta(key, searchedKey)
  if type(metadata[key]) == 'table' and searchedKey then
    return metadata[key][searchedKey]
  end
  return metadata[key]
end

function setMeta(key, value, newValue)
  if type(metadata[key]) == 'table' and newValue then
    metadata[key][value] = newValue
    return
  end
  metadata[key] = value
end

print("GET DEFAULT VALUES")
printTable(getMeta("table_data"))
print("SET NEW VALUE ONLY WATER TO 600")
setMeta("table_data", "water", 600)
print("GET ONLY WATER VALUE")
printTable(getMeta("table_data","water"))
print("------------------------------------")
print("DEFAULT SET VERSION WORKS {bread =  200, water =  300}")
setMeta("table_data", {bread =  200, water =  300})
print("GET DEFAULT VALUES")
printTable(getMeta("table_data"))

Gellipapa · 2023-02-22T10:04:02Z

You can do index, but why do this or you can use default version can set all table -> backwards compatiblity. Sorry guys i should go to work.

Gellipapa · 2023-02-22T10:07:06Z

Next level if i can search in one value, why can't we pass it a table if i only need 5 out of 20 values, same with update, it would be nice to update those 5 values in order. 👍

Rav3n95 · 2023-02-22T11:35:02Z

Also play a violin and a guitar in a same time ;)

Rav3n95 · 2023-02-22T11:59:51Z

RegisterCommand('meta', function(source)
    local xPlayer = ESX.GetPlayerFromId(source)
    print('--------------------------------------------')
    print('Clearing "shopPrices" meta')
    xPlayer.clearMeta('shopPrices')
    print('First meta getter')
    print(json.encode(xPlayer.getMeta(),{indent=true}))
    print('--------------------------------------------')
    print('Setting "shopPrices" meta')
    xPlayer.setMeta('shopPrices', {bread = 200, water = 300})
    print('--------------------------------------------')
    print('Second meta getter')
    print(json.encode(xPlayer.getMeta(),{indent=true}))
    print('--------------------------------------------')
    print('Setting "bread" value on "shopPrices" meta')
    xPlayer.setMeta('shopPrices', 'bread', 250)
    print('Third meta getter -> just getting the bread price')
    print(xPlayer.getMeta('shopPrices', 'bread'))
    print('--------------------------------------------')
    print('Forth meta getter')
    print(json.encode(xPlayer.getMeta(),{indent=true}))
end, false)

Gellipapa

Nice good job, thank you buddy. 👍

[core]/.gitignore

mrscriptsid · 2023-02-26T19:31:17Z

cool, its posible to direct save when set meta?

Rav3n95 · 2023-02-26T19:54:37Z

cool, its posible to direct save when set meta?

If you are using the ESX.Saveplayer() function after you set the meta 🤣

mrscriptsid · 2023-02-26T20:07:47Z

cool, its posible to direct save when set meta?

If you are using the ESX.Saveplayer() function after you set the meta 🤣

i just set player detail (first lastname, bod, sex, height, etc) as a meta, but i have issue when get the meta, give me nil value

GetCharacters = function(source,data,slots)
	local characters = {}
	local license = ESX.GetIdentifier(source)
	local id = Config.Prefix..'%:'..license
	local data = MySQL.query.await('SELECT * FROM users WHERE identifier LIKE ?', {'%'..id..'%'})
	if data then
		for k,v in pairs(data) do
			local job, grade = v.job or 'imigran', tostring(v.job_grade)
			local accounts = json.decode(v.accounts)
			local id = tonumber(string.sub(v.identifier, #Config.Prefix+1, string.find(v.identifier, ':')-1))
			local xPlayer = ESX.GetPlayerFromId(source)
			print(xPlayer.getMeta('detail','firstname'))
		end
	end
	return {characters = characters , slots = slots}
end

Gellipapa · 2023-02-26T20:12:09Z

cool, its posible to direct save when set meta?

If you are using the ESX.Saveplayer() function after you set the meta 🤣

i just set player detail (first lastname, bod, sex, height, etc) as a meta, but i have issue when get the meta, give me nil value

GetCharacters = function(source,data,slots)
	local characters = {}
	local license = ESX.GetIdentifier(source)
	local id = Config.Prefix..'%:'..license
	local data = MySQL.query.await('SELECT * FROM users WHERE identifier LIKE ?', {'%'..id..'%'})
	if data then
		for k,v in pairs(data) do
			local job, grade = v.job or 'imigran', tostring(v.job_grade)
			local accounts = json.decode(v.accounts)
			local id = tonumber(string.sub(v.identifier, #Config.Prefix+1, string.find(v.identifier, ':')-1))
			local xPlayer = ESX.GetPlayerFromId(source)
			print(xPlayer.getMeta('detail','firstname'))
		end
	end
	return {characters = characters , slots = slots}
end

Hi! If you print json.encode(xPlayer.getMeta('detail')) what is get?

mrscriptsid · 2023-02-26T20:52:47Z

cool, its posible to direct save when set meta?

If you are using the ESX.Saveplayer() function after you set the meta 🤣

i just set player detail (first lastname, bod, sex, height, etc) as a meta, but i have issue when get the meta, give me nil value

GetCharacters = function(source,data,slots)
	local characters = {}
	local license = ESX.GetIdentifier(source)
	local id = Config.Prefix..'%:'..license
	local data = MySQL.query.await('SELECT * FROM users WHERE identifier LIKE ?', {'%'..id..'%'})
	if data then
		for k,v in pairs(data) do
			local job, grade = v.job or 'imigran', tostring(v.job_grade)
			local accounts = json.decode(v.accounts)
			local id = tonumber(string.sub(v.identifier, #Config.Prefix+1, string.find(v.identifier, ':')-1))
			local xPlayer = ESX.GetPlayerFromId(source)
			print(xPlayer.getMeta('detail','firstname'))
		end
	end
	return {characters = characters , slots = slots}
end

Hi! If you print json.encode(xPlayer.getMeta('detail')) what is get?

still error, fyi: i have string and number value on detail meta

Rav3n95 · 2023-02-26T21:46:56Z

cool, its posible to direct save when set meta?

If you are using the ESX.Saveplayer() function after you set the meta 🤣

i just set player detail (first lastname, bod, sex, height, etc) as a meta, but i have issue when get the meta, give me nil value
GetCharacters = function(source,data,slots)
	local characters = {}
	local license = ESX.GetIdentifier(source)
	local id = Config.Prefix..'%:'..license
	local data = MySQL.query.await('SELECT * FROM users WHERE identifier LIKE ?', {'%'..id..'%'})
	if data then
		for k,v in pairs(data) do
			local job, grade = v.job or 'imigran', tostring(v.job_grade)
			local accounts = json.decode(v.accounts)
			local id = tonumber(string.sub(v.identifier, #Config.Prefix+1, string.find(v.identifier, ':')-1))
			local xPlayer = ESX.GetPlayerFromId(source)
			print(xPlayer.getMeta('detail','firstname'))
		end
	end
	return {characters = characters , slots = slots}
end
Hi! If you print json.encode(xPlayer.getMeta('detail')) what is get?
still error, fyi: i have string and number value on detail meta

Why don't you use the data from sql? v.meta its there is v.job

Rav3n95 · 2023-02-26T21:48:20Z

Also you have a modified server bud, don't be surprise.

Gellipapa · 2023-02-26T22:01:41Z

@gerung It's works perfectly, i think you've got the problem.

mrscriptsid · 2023-02-27T01:34:57Z

@gerung It's works perfectly, i think you've got the problem.

I got an issue when I first spawn when the player already loaded everything fine, but when first spawn xPlayer was not ready to read so I got the issue. I'm using multicharacter and I thing that is the issue

Gellipapa · 2023-02-27T09:35:15Z

@gerung
I also use multicharacter, I don't understand what first spawn is. So when you see your character you already have xPlayer so you will getMeta as well as other xPlayer function. It won't before since you get xPlayer in the playerLoad event.

Gellipapa · 2023-02-27T09:36:52Z

I assume you mean when you're in the "lobby" or when you're choosing a character. There will be no xPlayer there yet so yes getMeta will not work as well as xPlayer.identifier because xPlayer is nil.

If this is your problem you will have to write a database query to get the meta data. It's like a column that can be queried by just json.decode the contents of the column to get a usable LUA table that you can index later.

Gellipapa · 2023-02-27T09:40:18Z

If you still don't have this problem, write down a sequence of reproducible steps that we can use to trigger the problem.

CsokiHUN · 2023-02-27T09:42:44Z

For multicharacter, as long as the player is not spawned, only the character is in the selector, xPlayer has no value in my opinion

mrscriptsid · 2023-03-01T05:42:07Z

I assume you mean when you're in the "lobby" or when you're choosing a character. There will be no xPlayer there yet so yes getMeta will not work as well as xPlayer.identifier because xPlayer is nil.

If this is your problem you will have to write a database query to get the meta data. It's like a column that can be queried by just json.decode the contents of the column to get a usable LUA table that you can index later.

solved, thanks

mrscriptsid · 2023-03-01T10:34:47Z

@Rav3n95 is there any option to get meta on client side?

Rav3n95 · 2023-03-01T10:35:42Z

If you are using Legacy it's synced into Playerdata

mrscriptsid · 2023-03-05T09:22:19Z

i have issue when set the meta, for example i have this meta on db
{"chardata":{"dateofbirth":"2023-03-14","height":100,"injail":0,"isdead":false,"firstname":"Herman","ishandcuffed":false,"lastname":"Ringgo","ispunishment":0,"sex":"m"}}
and trying to test with this command

RegisterCommand('test', function(source)
    local src = source
    local xPlayer = ESX.GetPlayerFromId(src)
    xPlayer.setMeta('chardata', 'ishandcuffed', true)
end, true)

but the existing meta is replaced with this {"chardata":{"ishandcuffed":true}}

hmm

Rav3n95 · 2023-03-05T09:45:18Z

Are you using the Dev branch of esx?

mrscriptsid · 2023-03-05T09:56:15Z

Are you using the Dev branch of esx?

no, using the "Main" esx

Rav3n95 · 2023-03-05T10:10:46Z

It's not even on the main yet

mrscriptsid · 2023-03-05T10:17:47Z

It's not even on the main yet

i just tried your metadata on main esx

Rav3n95 · 2023-03-05T10:43:24Z

You forgot to copy something then, cuz it's already been use on a live server

Gellipapa · 2023-03-05T14:20:03Z

es_extended_currenty_dev.zip

@ucingoyen Hi! Download this zip and drag and drop and overwrite your es_extended(but make backup save) this is include metadata system.

Rav3n95 added 2 commits February 21, 2023 23:18

feat: esx:updatePlayerData

c078342

feat: Metadata

5a5d4bb

CsokiHUN requested changes Feb 21, 2023

View reviewed changes

[core]/es_extended/server/main.lua Outdated Show resolved Hide resolved

Rav3n95 added 2 commits February 21, 2023 23:39

fix: (Metadata) small fixes

3ce044e

fix:(Metadata) Remove forgotten debug print

31a7f02

Rav3n95 requested a review from CsokiHUN February 21, 2023 22:41

Fix: (Metadata) Forgotten statebag setter

c0a151a

CsokiHUN approved these changes Feb 22, 2023

View reviewed changes

Feat: (Metadata) subModule

5dedf4f

fix: (Metadata) string check on getMeta

cd5b562

Gellipapa approved these changes Feb 22, 2023

View reviewed changes

Rav3n95 requested review from CsokiHUN and TheFantomas February 22, 2023 12:27

Rav3n95 added 2 commits February 22, 2023 14:06

Fix: Remove gitignore, and sql update

3d5deda

Why do we have 2 sql?

9d16575

TheFantomas approved these changes Feb 22, 2023

View reviewed changes

[core]/.gitignore Outdated Show resolved Hide resolved

Small fixes

9ab108e

Rav3n95 merged commit e8ac189 into esx-framework:dev Feb 26, 2023

feat: Metadata #912

feat: Metadata #912

Conversation

Rav3n95 commented Feb 21, 2023

CsokiHUN left a comment

Choose a reason for hiding this comment

Gellipapa commented Feb 22, 2023

CsokiHUN commented Feb 22, 2023

Gellipapa commented Feb 22, 2023 • edited

Rav3n95 commented Feb 22, 2023

Gellipapa commented Feb 22, 2023

CsokiHUN commented Feb 22, 2023

Rav3n95 commented Feb 22, 2023

CsokiHUN commented Feb 22, 2023

Gellipapa commented Feb 22, 2023

Gellipapa commented Feb 22, 2023

Rav3n95 commented Feb 22, 2023

Gellipapa commented Feb 22, 2023

Rav3n95 commented Feb 22, 2023

CsokiHUN commented Feb 22, 2023

Gellipapa commented Feb 22, 2023

Gellipapa commented Feb 22, 2023

Gellipapa commented Feb 22, 2023

Rav3n95 commented Feb 22, 2023

Rav3n95 commented Feb 22, 2023

Gellipapa left a comment

Choose a reason for hiding this comment

mrscriptsid commented Feb 26, 2023

Rav3n95 commented Feb 26, 2023

mrscriptsid commented Feb 26, 2023 • edited

Gellipapa commented Feb 26, 2023

mrscriptsid commented Feb 26, 2023 • edited

Rav3n95 commented Feb 26, 2023

Rav3n95 commented Feb 26, 2023

Gellipapa commented Feb 26, 2023

mrscriptsid commented Feb 27, 2023

Gellipapa commented Feb 27, 2023 • edited

Gellipapa commented Feb 27, 2023 • edited

Gellipapa commented Feb 27, 2023

CsokiHUN commented Feb 27, 2023

mrscriptsid commented Mar 1, 2023

mrscriptsid commented Mar 1, 2023

Rav3n95 commented Mar 1, 2023

mrscriptsid commented Mar 5, 2023 • edited

Rav3n95 commented Mar 5, 2023

mrscriptsid commented Mar 5, 2023

Rav3n95 commented Mar 5, 2023

mrscriptsid commented Mar 5, 2023

Rav3n95 commented Mar 5, 2023

Gellipapa commented Mar 5, 2023

Gellipapa commented Feb 22, 2023 •

edited

mrscriptsid commented Feb 26, 2023 •

edited

mrscriptsid commented Feb 26, 2023 •

edited

Gellipapa commented Feb 27, 2023 •

edited

Gellipapa commented Feb 27, 2023 •

edited

mrscriptsid commented Mar 5, 2023 •

edited