esy install: Cannot read property 'length' of undefined (Ubuntu)

[IwanKaramazow]

Steps to reproduce:

git clone https://github.com/iwankaramazow/track
cd track
docker build -t track .
docker run -it track
esy install

The dockerfile starts with the base ubuntu:17.10 image, installs node & esy.
As soon as I run esy install in the dockercontainer (e.g. on a ci), node crashes with

  TypeError: Cannot read property 'length' of undefined
      at Object.add_string (/usr/local/lib/node_modules/esy/node_modules/@esy-ocaml/esy-opam/dist/esy-opam.js:44669:15)
      at strput_acc (/usr/local/lib/node_modules/esy/node_modules/@esy-ocaml/esy-opam/dist/esy-opam.js:52981:25)
      at strput_acc (/usr/local/lib/node_modules/esy/node_modules/@esy-ocaml/esy-opam/dist/esy-opam.js:52983:11)
      at Object.strput_acc (/usr/local/lib/node_modules/esy/node_modules/@esy-ocaml/esy-opam/dist/esy-opam.js:52980:11)
      at k$prime (/usr/local/lib/node_modules/esy/node_modules/@esy-ocaml/esy-opam/dist/esy-opam.js:64574:24)
      at Object._2 (/usr/local/lib/node_modules/esy/node_modules/@esy-ocaml/esy-opam/dist/esy-opam.js:56228:12)
      at make_printf (/usr/local/lib/node_modules/esy/node_modules/@esy-ocaml/esy-opam/dist/esy-opam.js:52214:20)
      at /usr/local/lib/node_modules/esy/node_modules/@esy-ocaml/esy-opam/dist/esy-opam.js:52707:20
      at app (/usr/local/lib/node_modules/esy/node_modules/@esy-ocaml/esy-opam/dist/esy-opam.js:56125:16)
      at curry_2 (/usr/local/lib/node_modules/esy/node_modules/@esy-ocaml/esy-opam/dist/esy-opam.js:56197:18)

The stack trace & other logs can be found at
https://gist.github.com/IwanKaramazow/a00d813c9f4f9b6e7f8864aa37f1c972

The ubuntu-container probably misses some utility. What kind of tools are missing? Can we throw a warning if they aren't installed? Is that tool windows-proof?

[andreypopp]

Traceback originates from BS compiled esy-opam package.

[andreypopp]

UnixNode.getlogin returns undefined for root.

[andreypopp]

Fixed in esy@0.0.30 it can be installed as npm i -g esy@next at this time.

Also your Dockerfile seems to be missing apt-get install xz-utils.

[andreypopp]

Btw. apt-get install bzip2 is also missing from the Dockerfile. Currently we spawn tar process in esy-install as npm packages for tar/gzip/bzip2 weren't able all the variety of tarballs we have on opam. I

Regarding the docker workflow — don't you think that it's better to ship a preinstalled node_modules in docker image so you don't have to run installation in it? As I understand docker workflow is made for cross compilation here?

[IwanKaramazow]

Thanks for the quick fix!

don't you think that it's better to ship a preinstalled node_modules in docker image so you don't have to run installation in it
but I probably cannot ship a preinstalled node_modules from my mac to a linux docker container?I'm using docker for cross compilation