increase RLIMIT_NOFILE locally on Linux and macOS #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@EduardoRFS Since we're touching the system settings, I think we should do this behind a prompt once we find that the limits arent high enough |
|
@prometheansacrifice this isn't system settings, is only related to the session inside of esy, so |
|
Ah, I misunderstood. |
|
Nice, thanks @EduardoRFS ! I hit this all the time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #1057
Revery is working with this patch without using
ulimitHow it works
It uses
setrlimitto increase RLIMIT_NOFILE to 4096 if it isn't big enough, this should be completely safe assetrlimitapplies only to the current process and his children.