Use vendored bos to remove files/directories #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManasJayanth
force-pushed
the
prometheansacrifice/windows-fix-esy-cached-tarballs
branch
from
43e3ab1
to
1db37c5
Compare
ManasJayanth
force-pushed
the
prometheansacrifice/windows-fix-esy-cached-tarballs
branch
2 times, most recently
from
bfac631
to
134c265
Compare
|
@ManasJayanth does this solve the problem on Windows where users needs to delete a folder by hand? |
|
I think so - one of the reasons someone would have to manually force delete a directory was, if it contained a files with readonly attr set - the vendored Bos takes care of that. |
|
This PR needs more work though |
ManasJayanth
changed the title
ManasJayanth
changed the title
ManasJayanth
force-pushed
the
prometheansacrifice/windows-fix-esy-cached-tarballs
branch
3 times, most recently
from
40fe438
to
6de9525
Compare
Vendored bos has fixes for readonly files on Windows. Issue last seen with esy i --cache-tarballs-path
ManasJayanth
force-pushed
the
prometheansacrifice/windows-fix-esy-cached-tarballs
branch
from
6de9525
to
2ecd270
Compare
ManasJayanth
force-pushed
the
prometheansacrifice/windows-fix-esy-cached-tarballs
branch
from
2ecd270
to
9b7beea
Compare
ManasJayanth
force-pushed
the
prometheansacrifice/windows-fix-esy-cached-tarballs
branch
from
5dcd84b
to
621b523
Compare
ManasJayanth
deleted the
prometheansacrifice/windows-fix-esy-cached-tarballs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vendored bos has fixes for readonly files on Windows. Issue last seen
with esy i --cache-tarballs-path