Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement fastbuild workflow #23

Merged
merged 43 commits into from
Nov 6, 2017
Merged

Implement fastbuild workflow #23

merged 43 commits into from
Nov 6, 2017

Conversation

andreypopp
Copy link
Member

@andreypopp andreypopp commented Nov 3, 2017 •
edited
Loading

WIP: DO NOT MERGE

Implements #10

  • Refactor makefile builder & makefile builder runtime to reuse runtime in ejected bash script
  • Support for _build for root build types
    • simple-builder
    • makefile-builder
  • Add "esy.install" support
    • simple-builder
    • makefile-builder
  • Eject build script for to workaround Node startup (shell-builder)
    • Check if script should be reejected (same check as with ejected env)
    • Run root project build
    • Run linked project builds
  • Add support for esy build <anycommand>
    • shell-builder
    • simple-builder
    • Export $TERM (for pretty command output, don't think it would hurt much)
  • command env
    • Make esy <anycommand>/esy shell not include root paths
    • Update release to include proper command env
  • Tests

@andreypopp
Allow buildsInSource to be _build
eceac02
@andreypopp
Remove mutatesSourcePath, do not relocate root build with _build
69ecc66
@andreypopp
Tweak sandbox rules for .merlin
abb808f
@andreypopp
Change build tree symlinks behaviour
c483c3d 
* Rename them to `_build` and `_install`.
* Do not set them if `buildType == "_build"`
@andreypopp
makefile-builder: prepare sandbox.sb as a separate rule
a391ffe
@andreypopp
Refactor Makefile generation
f289ca6 
Now we construct dependency graph directly referencing rules not relying
on ids.
@andreypopp
Update flow
21cdc71
@andreypopp
More regular types for build tasks
48b5950
@andreypopp
Group rules for Makefile
4065800
@andreypopp
Proper clean rule for Makefile builder
8ec09fc
@andreypopp
Makefile builder stores commands in an array
c30d7a0
@andreypopp
Add "esy.install" key
310029d
@andreypopp
Remove exposeOwnPath from build task creation
e6c3d0c
@andreypopp
Fix comment
70cc2ca
@andreypopp
Fix how we compile empty arrays in Makefile
96131fa
@andreypopp
makefile: Reuse sandbox env in build specific envs
614dafc
@andreypopp
More cleanups for makefile runtime
5ce2b50
@andreypopp
makefile: cleanups
d4af842
@andreypopp
makefile: makefile-builder-runtime.sh -> shell-builder.sh
a63f542
@andreypopp
Rename build commands in runtime, split install phase
05ade06
@andreypopp
Add new sourceType: 'root'
a555a21
@andreypopp
Pass sandbox.sb as config to shell builder
8fef024
@andreypopp
Allow creating *.install files for '_build'-builds
beb6114
@andreypopp
Cleanup condition for source reloc
4ae2ecb
@andreypopp
Eject build for root into shell
1f205ab
@andreypopp
Allow ejected builds to execute arbitrary command
ea167f9
@andreypopp
shell-builder: cleanup
1a708b7
@andreypopp
Add docs for shell-builder
9dea392
@andreypopp
Update docs, tidy up bin/esy
75da584
@jordwalke jordwalke mentioned this pull request Nov 3, 2017
Merged
@jordwalke
Copy link
Member

Does it save us time to consider the makefile-builder mode as being only for ejecting releases?

@andreypopp
Copy link
Member Author

@jordwalke we treat it that way already

@andreypopp andreypopp merged commit 9c77536 into master Nov 6, 2017
@andreypopp andreypopp deleted the feat/fastbuild branch November 6, 2017 17:03
@zploskey zploskey mentioned this pull request Nov 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andreypopp @jordwalke