Use shorter build path to avoid long path issues on Windows #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManasJayanth
force-pushed
the
prometheansacrifice/use-shorter-global-build-path
branch
from
0ce6988
to
aa74533
Compare
|
Please don't merge it just yet |
When packages need deep nested paths (like ocaml-migrate-parsetree. See https://gist.github.com/prometheansacrifice/7309940918d646d465d9d6abd0a5d231), packages fail to build (despite having enabled long paths). This PR uses a shorter path for global build cache.
ManasJayanth
force-pushed
the
prometheansacrifice/use-shorter-global-build-path
branch
from
8527211
to
928c68d
Compare
|
Tested and works fine with OCaml Parse Migratetree |
andreypopp
reviewed
Aug 30, 2019
| storePath: EsyLib.Path.t, | ||
| localStorePath: EsyLib.Path.t, | ||
| disableSandbox: bool, | ||
| }; |
There was a problem hiding this comment.
Is there a way we could keep only three paths there — project path, path for immutable builds (global store) and path for transient builds (local store)?
I think here we could determine storePath out of globalStorePrefix, right?
There was a problem hiding this comment.
Yeah, we can definitely do that. I'll be on it.
ManasJayanth
changed the title
ManasJayanth
force-pushed
the
prometheansacrifice/use-shorter-global-build-path
branch
from
4f01a75
to
11e08b0
Compare
ManasJayanth
changed the title
|
Thanks @prometheansacrifice ! |
|
Good to merge @andreypopp? This could get rid of a huge set of potential windows build failures (though I haven't seen any lately). |
This reverts commit df516af.
ManasJayanth
force-pushed
the
prometheansacrifice/use-shorter-global-build-path
branch
from
2e8325e
to
be00486
Compare
ManasJayanth
deleted the
prometheansacrifice/use-shorter-global-build-path
branch
|
Sorry, missed the notification. Glad to see this merged! |
ManasJayanth
added a commit
that referenced
this pull request
Oct 16, 2019
ManasJayanth
added a commit
that referenced
this pull request
Oct 19, 2019
jordwalke
pushed a commit
that referenced
this pull request
Oct 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses shorted build path /.esy//b
When packages need deep nested paths (like
ocaml-migrate-parsetree. See
https://gist.github.com/prometheansacrifice/7309940918d646d465d9d6abd0a5d231),
packages fail to build (despite having enabled long paths). This PR
uses a shorter path for global build cache.