chore: make conditional more clear

eta-dev · May 29, 2023 · ea37ebb · ea37ebb
1 parent e30a863
commit ea37ebb
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 252 deletions.
diff --git a/src/core.ts b/src/core.ts
@@ -52,12 +52,14 @@ export class Eta {
     template: string | TemplateFunction, // template string or template function
     options?: { async: boolean }
   ): void {
-    let templates = options && options.async ? this.templatesAsync : this.templatesSync;
-
     if (typeof template === "string") {
+      const templates = options && options.async ? this.templatesAsync : this.templatesSync;
+
       templates.define(name, this.compile(template, options));
     } else {
-      if (template.constructor.name === "AsyncFunction") {
+      let templates = this.templatesSync;
+
+      if (template.constructor.name === "AsyncFunction" || (options && options.async)) {
         templates = this.templatesAsync;
       }
 

diff --git a/test/file-handlers.spec.ts b/test/file-handlers.spec.ts
diff --git a/test/file-helpers.spec.ts b/test/file-helpers.spec.ts
diff --git a/test/helpers.spec.ts b/test/helpers.spec.ts