-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deno): support Deno 1.4.0 strict type checks #20
fix(deno): support Deno 1.4.0 strict type checks #20
Conversation
@asos-craigmorten thanks for the PR! It looks perfect -- I'll merge it now. I'm hopeful it won't cause breaking changes for any users, because Eta uses Thanks again! Note: just published to https://deno.land/x/eta@v1.7.0. I can create a PR to update the version in Opine if you'd like |
By the way, do you mind if I add you to the README as a contributor? |
@nebrelbug awesome! Feel free to add me if you like 😄 Keep up the great work! Dw about Opine, have a PR already open tracking the required dependency updates 🙃 |
@all-contributors please add @asos-craigmorten for code |
Hmm... I'll try again. @all-contributors please add @asos-craigmorten for code |
Okay, just fixed a bot config issue 😃. @all-contributors please add @asos-craigmorten for code |
I've put up a pull request to add @asos-craigmorten! 🎉 |
@asos-craigmorten finally added you, after messing with the GitHub bot a little 🤣 Thanks again for the PR! I'm excited to see what people build with Opine and Eta. I just added a feature which drastically improves Eta's speed w/ Opine, and should make Eta by far the fastest Deno template engine ⚡ 😁 |
Fixes #19
Please note that this removes backcompat with TypeScript versions prior to 3.8 (REF: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html), please flag if that is an issue!