Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deno): support Deno 1.4.0 strict type checks #20

Merged
merged 1 commit into from
Sep 15, 2020
Merged

fix(deno): support Deno 1.4.0 strict type checks #20

merged 1 commit into from
Sep 15, 2020

Conversation

asos-craigmorten
Copy link

@asos-craigmorten asos-craigmorten commented Sep 15, 2020

Fixes #19

Please note that this removes backcompat with TypeScript versions prior to 3.8 (REF: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html), please flag if that is an issue!

@nebrelbug
Copy link
Collaborator

nebrelbug commented Sep 15, 2020

@asos-craigmorten thanks for the PR! It looks perfect -- I'll merge it now.

I'm hopeful it won't cause breaking changes for any users, because Eta uses export * as ns Syntax already.... I guess I'll know if people start submitting issues 🤣 🤞

Thanks again!

Note: just published to https://deno.land/x/eta@v1.7.0. I can create a PR to update the version in Opine if you'd like

@nebrelbug nebrelbug merged commit 7690d06 into eta-dev:master Sep 15, 2020
@nebrelbug
Copy link
Collaborator

By the way, do you mind if I add you to the README as a contributor?

@asos-craigmorten
Copy link
Author

@nebrelbug awesome!

Feel free to add me if you like 😄 Keep up the great work!

Dw about Opine, have a PR already open tracking the required dependency updates 🙃

@asos-craigmorten asos-craigmorten deleted the fix/support-deno-1.4.0 branch September 15, 2020 15:45
@nebrelbug
Copy link
Collaborator

@all-contributors please add @asos-craigmorten for code

@nebrelbug
Copy link
Collaborator

Hmm... I'll try again. @all-contributors please add @asos-craigmorten for code

@nebrelbug
Copy link
Collaborator

Okay, just fixed a bot config issue 😃. @all-contributors please add @asos-craigmorten for code

@allcontributors
Copy link
Contributor

@nebrelbug

I've put up a pull request to add @asos-craigmorten! 🎉

@nebrelbug
Copy link
Collaborator

@asos-craigmorten finally added you, after messing with the GitHub bot a little 🤣

Thanks again for the PR! I'm excited to see what people build with Opine and Eta. I just added a feature which drastically improves Eta's speed w/ Opine, and should make Eta by far the fastest Deno template engine ⚡ 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Deno 1.4.0 Strict Type Import / Export
3 participants