Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the splitting of documents in eval retriever #12

Merged
merged 0 commits into from
Jan 25, 2021

Conversation

Rob192
Copy link
Contributor

@Rob192 Rob192 commented Jan 22, 2021

This is to add the splitting function to our retriever evaluation.

The splitting function for the eval data is a new fixture as it was released recently. there may still be some edges cases. At least I referenced one here : deepset-ai/haystack#751 where the script does not work in some specific case (short sentences and anwser at the very beginning of the context).

However, is likely to improved in a near future and allows us to start evaluating the performances of the full stack with different cuts.

@Rob192 Rob192 requested a review from psorianom January 22, 2021 15:20
@psorianom
Copy link
Contributor

cool! let's go!

@psorianom psorianom merged this pull request into master Jan 25, 2021
@psorianom psorianom deleted the 'add_preprocessing_splits' branch January 25, 2021 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants