Render description field in Markdown #39

AntoineAugusti · 2019-12-23T17:52:57Z

Fixes #32

package.json

abulte

Thoughts for later: we probably should factorize more things between each field component. You just made 2 PRs that made the same set of changes in 3 different files.

AntoineAugusti · 2019-12-23T18:29:39Z

True. There is room for improvements.

I'm sure the form group thing can go in a shared component and we can leverage templates. I'll open a follow-up refactor issue 👌

Render field description in Markdown

0088fc1

vercel bot deployed to staging December 23, 2019 17:53 View deployment

AntoineAugusti commented Dec 23, 2019

View reviewed changes

package.json Show resolved Hide resolved

AntoineAugusti changed the title ~~Render field description in Markdown~~ Render description field in Markdown Dec 23, 2019

AntoineAugusti requested a review from abulte December 23, 2019 17:54

abulte approved these changes Dec 23, 2019

View reviewed changes

AntoineAugusti mentioned this pull request Dec 23, 2019

Refactor input components #40

Closed

AntoineAugusti merged commit 03188f2 into master Dec 23, 2019

AntoineAugusti deleted the markdown-description branch December 23, 2019 18:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Render description field in Markdown #39

Render description field in Markdown #39

AntoineAugusti commented Dec 23, 2019 •

edited

abulte left a comment

AntoineAugusti commented Dec 23, 2019

Render description field in Markdown #39

Render description field in Markdown #39

Conversation

AntoineAugusti commented Dec 23, 2019 • edited

abulte left a comment

Choose a reason for hiding this comment

AntoineAugusti commented Dec 23, 2019

AntoineAugusti commented Dec 23, 2019 •

edited