Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set html lang and alternate lang urls #634

Merged
merged 3 commits into from
Jun 18, 2018
Merged

Conversation

tusbar
Copy link
Contributor

@tusbar tusbar commented Jun 1, 2018

This will prevent duplicate SE entries for different languages.

@tusbar tusbar added this to the 3.7.0 milestone Jun 1, 2018
@tusbar tusbar self-assigned this Jun 1, 2018
@jdesboeufs jdesboeufs temporarily deployed to geodatagouv-pr-634 June 1, 2018 10:27 Inactive
@buildsize
Copy link

buildsize bot commented Jun 1, 2018

File name Previous Size New Size Change
page-_error.js.gz 171 bytes 172 bytes 1 bytes (1%)
page-catalog.js.gz 57.61 KB 57.6 KB -4 bytes (0%)
page-catalogs.js.gz 3.71 KB 3.71 KB 0 bytes (0%)
page-dataset.js.gz 18.45 KB 18.45 KB -1 bytes (0%)
page-doc-publish-your-data.js.gz 3.75 KB 3.75 KB 0 bytes (0%)
page-doc.js.gz 1.92 KB 1.92 KB 0 bytes (0%)
page-events.js.gz 1.62 KB 1.62 KB 0 bytes (0%)
page-harvest.js.gz 3.14 KB 3.14 KB 0 bytes (0%)
page-index.js.gz 6.17 KB 6.17 KB 0 bytes (0%)
page-legal.js.gz 853 bytes 853 bytes 0 bytes (0%)
page-publication-datasets.js.gz 6.08 KB 6.08 KB 0 bytes (0%)
page-publication-organization.js.gz 9.65 KB 9.65 KB 0 bytes (0%)
page-publication-producers.js.gz 5.61 KB 5.61 KB 1 bytes (0%)
page-publication.js.gz 3.81 KB 3.81 KB 0 bytes (0%)
page-search.js.gz 7.99 KB 7.99 KB 1 bytes (0%)
page-doc-link-proxy.js.gz 1.49 KB 1.49 KB 0 bytes (0%)
page-embed-preview.js.gz 4.62 KB 4.62 KB 0 bytes (0%)
chunk-dataset_downloads_preview_table.js.gz 12.9 KB 12.9 KB 0 bytes (0%)
page-_app.js.gz 2.51 KB 2.78 KB 281 bytes (11%)
static-commons-main-[hash].js.gz 134.88 KB 134.96 KB 81 bytes (0%)
chunk-centered_map_map.js.gz 169.97 KB 169.97 KB 0 bytes (0%)

@codecov-io
Copy link

codecov-io commented Jun 1, 2018

Codecov Report

Merging #634 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #634      +/-   ##
=========================================
- Coverage    4.94%   4.93%   -0.01%     
=========================================
  Files         111     111              
  Lines        1477    1478       +1     
=========================================
  Hits           73      73              
- Misses       1404    1405       +1
Impacted Files Coverage Δ
server/index.js 0% <ø> (ø) ⬆️
lib/i18n.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67b238a...440e9e0. Read the comment docs.

@tusbar tusbar temporarily deployed to geodatagouv-pr-634 June 1, 2018 14:20 Inactive
@tusbar tusbar added the dependencies Issue related to dependencies label Jun 1, 2018
@tusbar tusbar temporarily deployed to geodatagouv-pr-634 June 1, 2018 14:23 Inactive
@tusbar tusbar temporarily deployed to geodatagouv-pr-634 June 1, 2018 14:34 Inactive
@tusbar tusbar temporarily deployed to geodatagouv-pr-634 June 1, 2018 14:35 Inactive
This will prevent duplicate SE entries for different languages.
Prevent from adding classNames to unwanted DOM nodes.
@tusbar tusbar merged commit 8746a0c into master Jun 18, 2018
@tusbar tusbar deleted the tusbar/i18n-improvments branch June 18, 2018 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Issue related to dependencies i18n seo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants