Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop mutating props in map component #646

Merged
merged 1 commit into from
Jun 19, 2018
Merged

Conversation

tusbar
Copy link
Contributor

@tusbar tusbar commented Jun 19, 2018

This prevents $GDV_UNIQUE_FEATURE_ID$ from showing in the preview table and will allow re-rendering if any prop changes.

@buildsize
Copy link

buildsize bot commented Jun 19, 2018

File name Previous Size New Size Change
page-_error.js.gz 172 bytes 172 bytes 0 bytes (0%)
page-catalog.js.gz 57.57 KB 57.57 KB 0 bytes (0%)
page-catalogs.js.gz 3.71 KB 3.71 KB 0 bytes (0%)
page-dataset.js.gz 18.54 KB 18.54 KB 0 bytes (0%)
page-doc-publish-your-data.js.gz 3.75 KB 3.75 KB 0 bytes (0%)
page-doc.js.gz 1.92 KB 1.92 KB 0 bytes (0%)
page-events.js.gz 2.52 KB 2.52 KB 0 bytes (0%)
page-harvest.js.gz 3.14 KB 3.14 KB 0 bytes (0%)
page-index.js.gz 6.24 KB 6.24 KB 0 bytes (0%)
page-legal.js.gz 853 bytes 853 bytes 0 bytes (0%)
page-publication-datasets.js.gz 6.14 KB 6.14 KB 0 bytes (0%)
page-publication-organization.js.gz 9.76 KB 9.76 KB 0 bytes (0%)
page-publication-producers.js.gz 5.67 KB 5.67 KB 0 bytes (0%)
page-publication.js.gz 3.88 KB 3.88 KB 0 bytes (0%)
page-search.js.gz 7.99 KB 7.99 KB 0 bytes (0%)
page-doc-link-proxy.js.gz 1.49 KB 1.49 KB 0 bytes (0%)
page-embed-preview.js.gz 4.62 KB 4.62 KB 0 bytes (0%)
chunk-dataset_downloads_preview_table.js.gz 12.96 KB 12.96 KB 0 bytes (0%)
page-_app.js.gz 2.78 KB 2.78 KB 0 bytes (0%)
static-commons-main-[hash].js.gz 136.06 KB 136.06 KB 5 bytes (0%)
chunk-centered_map_map.js.gz 169.98 KB 170.54 KB 578 bytes (0%)

@codecov-io
Copy link

Codecov Report

Merging #646 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #646      +/-   ##
=========================================
- Coverage    4.93%   4.88%   -0.05%     
=========================================
  Files         111     112       +1     
  Lines        1480    1493      +13     
=========================================
  Hits           73      73              
- Misses       1407    1420      +13
Impacted Files Coverage Δ
components/centered-map/enhance-map-data.js 0% <0%> (ø)
components/centered-map/map.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 317e793...a9a3140. Read the comment docs.

Copy link
Member

@jdesboeufs jdesboeufs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tusbar tusbar merged commit 0974862 into master Jun 19, 2018
@tusbar tusbar deleted the tusbar/stop-altering-props branch June 19, 2018 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants