Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display entire france for empty datasets #649

Merged
merged 2 commits into from
Jul 13, 2018

Conversation

tusbar
Copy link
Contributor

@tusbar tusbar commented Jun 25, 2018

@turf/bbox with return [Infinity, Infinity, Infinity, Infinity] if the dataset is empty.

In that case we still display the map, centered on France.

@tusbar tusbar added the bug label Jun 25, 2018
@tusbar tusbar added this to the 3.7.1 milestone Jun 25, 2018
@tusbar tusbar self-assigned this Jun 25, 2018
@jdesboeufs jdesboeufs temporarily deployed to geodatagouv-pr-649 June 25, 2018 09:37 Inactive
@buildsize
Copy link

buildsize bot commented Jun 25, 2018

File name Previous Size New Size Change
page-_error.js.gz 172 bytes 172 bytes 0 bytes (0%)
page-catalog.js.gz 57.58 KB 57.58 KB 0 bytes (0%)
page-catalogs.js.gz 3.71 KB 3.71 KB 0 bytes (0%)
page-dataset.js.gz 18.54 KB 18.55 KB 10 bytes (0%)
page-doc-publish-your-data.js.gz 3.75 KB 3.75 KB 0 bytes (0%)
page-doc.js.gz 1.92 KB 1.92 KB 0 bytes (0%)
page-events.js.gz 2.47 KB 2.47 KB 0 bytes (0%)
page-harvest.js.gz 3.14 KB 3.14 KB 0 bytes (0%)
page-index.js.gz 6.24 KB 6.24 KB 0 bytes (0%)
page-legal.js.gz 853 bytes 853 bytes 0 bytes (0%)
page-publication-datasets.js.gz 6.14 KB 6.14 KB 0 bytes (0%)
page-publication-organization.js.gz 9.76 KB 9.76 KB 0 bytes (0%)
page-publication-producers.js.gz 5.67 KB 5.67 KB 0 bytes (0%)
page-publication.js.gz 3.88 KB 3.88 KB 0 bytes (0%)
page-search.js.gz 7.99 KB 7.99 KB 0 bytes (0%)
page-doc-link-proxy.js.gz 1.49 KB 1.49 KB 0 bytes (0%)
page-embed-preview.js.gz 4.62 KB 4.62 KB 0 bytes (0%)
chunk-dataset_downloads_preview_table.js.gz 12.96 KB 12.96 KB 0 bytes (0%)
page-_app.js.gz 2.78 KB 2.78 KB 0 bytes (0%)
static-commons-main-[hash].js.gz 136.07 KB 136.07 KB 1 bytes (0%)
chunk-centered_map_map.js.gz 171.8 KB 171.98 KB 182 bytes (0%)

@codecov-io
Copy link

codecov-io commented Jun 25, 2018

Codecov Report

Merging #649 into master will increase coverage by 0.03%.
The diff coverage is 7.69%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #649      +/-   ##
=========================================
+ Coverage     4.9%   4.93%   +0.03%     
=========================================
  Files         112     113       +1     
  Lines        1489    1498       +9     
=========================================
+ Hits           73      74       +1     
- Misses       1416    1424       +8
Impacted Files Coverage Δ
components/centered-map/enhance-map-data.js 0% <0%> (ø) ⬆️
components/centered-map/empty.js 0% <0%> (ø)
components/dataset/spatial-extent.js 0% <0%> (ø) ⬆️
components/centered-map/map.js 0% <0%> (ø) ⬆️
lib/geo/bbox.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5200aa9...5e9cfb5. Read the comment docs.

@tusbar tusbar temporarily deployed to geodatagouv-pr-649 June 25, 2018 12:28 Inactive
@tusbar
Copy link
Contributor Author

tusbar commented Jun 25, 2018

Example: https://geodatagouv-pr-649.herokuapp.com/fr/datasets/ef071ed1653b727062cef514c72dc957eea971cb

A small message is now displayed when the dataset is empty.

@tusbar tusbar force-pushed the tusbar/fix-map-for-empty-geojson branch from 90ff235 to 5e9cfb5 Compare July 12, 2018 13:03
@tusbar tusbar merged commit 349efff into master Jul 13, 2018
@tusbar tusbar deleted the tusbar/fix-map-for-empty-geojson branch July 13, 2018 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants