Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start map feature ids at 1 #652

Merged
merged 1 commit into from
Jul 12, 2018
Merged

Start map feature ids at 1 #652

merged 1 commit into from
Jul 12, 2018

Conversation

tusbar
Copy link
Contributor

@tusbar tusbar commented Jul 12, 2018

Starting with 0 seems to break mapbox-gl, resulting in an undefined id.
This fixes the highlight on the first feature of a dataset.

See https://geo.data.gouv.fr/en/datasets/6d0dfdf2ccb4c6f3fea807d3764b9fe49eb263f7

@tusbar tusbar added the bug label Jul 12, 2018
@tusbar tusbar added this to the 3.7.1 milestone Jul 12, 2018
@tusbar tusbar self-assigned this Jul 12, 2018
@tusbar tusbar requested a review from jdesboeufs July 12, 2018 08:56
@jdesboeufs jdesboeufs temporarily deployed to geodatagouv-pr-652 July 12, 2018 08:56 Inactive
@buildsize
Copy link

buildsize bot commented Jul 12, 2018

File name Previous Size New Size Change
page-_error.js.gz 172 bytes 172 bytes 0 bytes (0%)
page-catalog.js.gz 57.58 KB 57.58 KB 0 bytes (0%)
page-catalogs.js.gz 3.71 KB 3.71 KB 0 bytes (0%)
page-dataset.js.gz 18.54 KB 18.54 KB 0 bytes (0%)
page-doc-publish-your-data.js.gz 3.75 KB 3.75 KB 0 bytes (0%)
page-doc.js.gz 1.92 KB 1.92 KB 0 bytes (0%)
page-events.js.gz 2.47 KB 2.47 KB 0 bytes (0%)
page-harvest.js.gz 3.14 KB 3.14 KB 0 bytes (0%)
page-index.js.gz 6.24 KB 6.24 KB 0 bytes (0%)
page-legal.js.gz 853 bytes 853 bytes 0 bytes (0%)
page-publication-datasets.js.gz 6.14 KB 6.14 KB 0 bytes (0%)
page-publication-organization.js.gz 9.76 KB 9.76 KB 0 bytes (0%)
page-publication-producers.js.gz 5.67 KB 5.67 KB 0 bytes (0%)
page-publication.js.gz 3.88 KB 3.88 KB 0 bytes (0%)
page-search.js.gz 7.99 KB 7.99 KB 0 bytes (0%)
page-doc-link-proxy.js.gz 1.49 KB 1.49 KB 0 bytes (0%)
page-embed-preview.js.gz 4.62 KB 4.62 KB 0 bytes (0%)
chunk-dataset_downloads_preview_table.js.gz 12.96 KB 12.96 KB 0 bytes (0%)
page-_app.js.gz 2.78 KB 2.78 KB 0 bytes (0%)
static-commons-main-[hash].js.gz 136.06 KB 136.07 KB 4 bytes (0%)
chunk-centered_map_map.js.gz 171.8 KB 171.8 KB 0 bytes (0%)

@codecov-io
Copy link

codecov-io commented Jul 12, 2018

Codecov Report

Merging #652 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #652   +/-   ##
=====================================
  Coverage     4.9%   4.9%           
=====================================
  Files         112    112           
  Lines        1489   1489           
=====================================
  Hits           73     73           
  Misses       1416   1416
Impacted Files Coverage Δ
components/centered-map/enhance-map-data.js 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5c0d8a...7e93857. Read the comment docs.

Starting with 0 seems to break mapbox-gl, resulting in an undefined id.
This fixes the highlight on the first feature of a dataset.
@tusbar
Copy link
Contributor Author

tusbar commented Jul 13, 2018

Fixed in mapbox/mapbox-gl-js#6938

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants