Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to next 7.0.1 #709

Merged
merged 10 commits into from
Oct 2, 2018
Merged

Switch to next 7.0.1 #709

merged 10 commits into from
Oct 2, 2018

Conversation

tusbar
Copy link
Contributor

@tusbar tusbar commented Aug 24, 2018

Update next.js to 7.0.1. See https://nextjs.org/blog/next-7/ for changes.

Also update react and react-dom.

Remove now useless babel config and plugins now that we have webpack 4.

Close #749
Close #750
Close #753

@jdesboeufs jdesboeufs temporarily deployed to geodatagouv-pr-709 August 24, 2018 10:30 Inactive
@codecov-io
Copy link

codecov-io commented Aug 24, 2018

Codecov Report

Merging #709 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #709      +/-   ##
=========================================
- Coverage    5.27%   5.23%   -0.05%     
=========================================
  Files         113     113              
  Lines        1498    1510      +12     
=========================================
  Hits           79      79              
- Misses       1419    1431      +12
Impacted Files Coverage Δ
components/catalog/harvests/index.js 0% <ø> (ø) ⬆️
components/centered-map/index.js 0% <0%> (ø) ⬆️
components/dataset/downloads/preview.js 0% <0%> (ø) ⬆️
components/catalog-preview.js 0% <0%> (ø) ⬆️
components/dataset/discussions/list.js 0% <0%> (ø) ⬆️
components/meta.js 0% <0%> (ø) ⬆️
components/dataset/thumbnails.js 0% <0%> (ø) ⬆️
components/page/header/index.js 0% <0%> (ø) ⬆️
...onents/publication/organization/source-catalogs.js 0% <0%> (ø) ⬆️
components/catalog/statistics.js 0% <0%> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bae8369...61e4f9e. Read the comment docs.

@tusbar tusbar temporarily deployed to geodatagouv-pr-709 August 24, 2018 10:34 Inactive
@buildsize
Copy link

buildsize bot commented Aug 24, 2018

File name Previous Size New Size Change
page-_error.js.gz 164 bytes 185 bytes 21 bytes (13%)
page-catalog.js.gz 56.42 KB 56.54 KB 118 bytes (0%)
page-catalogs.js.gz 3.61 KB 3.55 KB -63 bytes (2%)
page-dataset.js.gz 18.49 KB 19.31 KB 841 bytes (4%)
page-doc-publish-your-data.js.gz 3.71 KB 3.7 KB -11 bytes (0%)
page-doc.js.gz 1.86 KB 1.91 KB 47 bytes (2%)
page-events.js.gz 2.35 KB 2.29 KB -60 bytes (2%)
page-harvest.js.gz 2.98 KB 3.05 KB 72 bytes (2%)
page-index.js.gz 5.85 KB 5.76 KB -93 bytes (2%)
page-legal.js.gz 818 bytes 806 bytes -12 bytes (1%)
page-publication-datasets.js.gz 5.96 KB 5.91 KB -52 bytes (1%)
page-publication-organization.js.gz 9.25 KB 10.35 KB 1.1 KB (12%)
page-publication-producers.js.gz 5.46 KB 5.39 KB -79 bytes (1%)
page-publication.js.gz 3.81 KB 3.75 KB -58 bytes (1%)
page-search.js.gz 7.68 KB 7.76 KB 84 bytes (1%)
page-doc-link-proxy.js.gz 1.46 KB 1.44 KB -12 bytes (1%)
page-embed-preview.js.gz 4.51 KB 4.78 KB 270 bytes (6%)
chunk-dataset_downloads_preview_table.js.gz 12.59 KB [deleted]
page-_app.js.gz 2.77 KB 2.8 KB 37 bytes (1%)
static-commons-main-[hash].js.gz 133.24 KB [deleted]
chunk-centered_map_map.js.gz 169.7 KB [deleted]
chunk-centered-map.[hash].js.gz [new file] 169.31 KB
chunk-commons.[hash].js.gz [new file] 124.51 KB
chunk-preview-table.[hash].js.gz [new file] 12.6 KB
runtime-main-[hash].js.gz [new file] 1.68 KB
runtime-webpack-[hash].js.gz [new file] 1.22 KB

@tusbar tusbar temporarily deployed to geodatagouv-pr-709 August 25, 2018 13:28 Inactive
@tusbar tusbar temporarily deployed to geodatagouv-pr-709 August 25, 2018 13:36 Inactive
@tusbar tusbar temporarily deployed to geodatagouv-pr-709 August 25, 2018 13:48 Inactive
@tusbar tusbar temporarily deployed to geodatagouv-pr-709 August 25, 2018 13:51 Inactive
@tusbar tusbar temporarily deployed to geodatagouv-pr-709 August 25, 2018 13:56 Inactive
@tusbar tusbar temporarily deployed to geodatagouv-pr-709 August 25, 2018 14:03 Inactive
next.config.js Outdated
@@ -57,6 +52,9 @@ module.exports = withConfig({
}))
}

const chunkFilename = dev ? '[name]' : '[name].[contenthash]'
config.output.chunkFilename = isServer ? `${chunkFilename}.js` : `static/chunks/${chunkFilename}.js`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tusbar tusbar temporarily deployed to geodatagouv-pr-709 August 27, 2018 09:20 Inactive
@tusbar tusbar temporarily deployed to geodatagouv-pr-709 August 27, 2018 09:43 Inactive
@tusbar tusbar temporarily deployed to geodatagouv-pr-709 August 27, 2018 10:46 Inactive
@tusbar tusbar temporarily deployed to geodatagouv-pr-709 August 27, 2018 14:33 Inactive
@tusbar tusbar temporarily deployed to geodatagouv-pr-709 August 27, 2018 14:40 Inactive
@tusbar tusbar temporarily deployed to geodatagouv-pr-709 August 27, 2018 15:18 Inactive
@tusbar tusbar temporarily deployed to geodatagouv-pr-709 August 27, 2018 15:21 Inactive
@tusbar tusbar temporarily deployed to geodatagouv-pr-709 August 27, 2018 15:26 Inactive
@tusbar tusbar temporarily deployed to geodatagouv-pr-709 August 27, 2018 15:29 Inactive
@tusbar tusbar temporarily deployed to geodatagouv-pr-709 August 28, 2018 15:14 Inactive
@tusbar tusbar temporarily deployed to geodatagouv-pr-709 August 31, 2018 08:51 Inactive
@tusbar tusbar temporarily deployed to geodatagouv-pr-709 September 6, 2018 10:31 Inactive
@tusbar tusbar changed the title [WIP] Switch to next 7 (webpack 4, babel 7, etc.) [WIP] Switch to next 7 Sep 6, 2018
@tusbar tusbar self-assigned this Sep 6, 2018
@tusbar tusbar force-pushed the tusbar/next-7 branch 2 times, most recently from 04ea189 to af128f5 Compare September 19, 2018 22:34
@tusbar tusbar force-pushed the tusbar/next-7 branch 3 times, most recently from 0ac00ad to 9422426 Compare October 2, 2018 12:34
@tusbar tusbar changed the title [WIP] Switch to next 7 Switch to next 7 Oct 2, 2018
@tusbar tusbar added this to the 3.8.0 milestone Oct 2, 2018
@tusbar tusbar added dependencies Issue related to dependencies build-process performance labels Oct 2, 2018
@tusbar tusbar changed the title Switch to next 7 Switch to next 7.0.1 Oct 2, 2018
@tusbar tusbar merged commit 1a5bade into master Oct 2, 2018
@tusbar tusbar deleted the tusbar/next-7 branch October 2, 2018 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-process dependencies Issue related to dependencies performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants