Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publication pages #715

Merged
merged 5 commits into from
Aug 27, 2018
Merged

Fix publication pages #715

merged 5 commits into from
Aug 27, 2018

Conversation

tusbar
Copy link
Contributor

@tusbar tusbar commented Aug 27, 2018

  • Use new React Context API for session context
  • Use translate() HOC for custom Link component to stop using old context API (+ add tests)
  • Move attachSession HOC to _app page
  • Remove deprecated UNSAFE_* lifecycle methods
  • Fix data.gouv.fr register link
  • Fix some CSS

@tusbar tusbar added the cleanup label Aug 27, 2018
@tusbar tusbar added this to the 3.8.0 milestone Aug 27, 2018
@tusbar tusbar self-assigned this Aug 27, 2018
@tusbar tusbar requested a review from tmerlier August 27, 2018 11:13
@jdesboeufs jdesboeufs temporarily deployed to geodatagouv-pr-715 August 27, 2018 11:13 Inactive
@buildsize
Copy link

buildsize bot commented Aug 27, 2018

File name Previous Size New Size Change
page-_error.js.gz 164 bytes 164 bytes 0 bytes (0%)
page-catalog.js.gz 56.39 KB 56.36 KB -26 bytes (0%)
page-catalogs.js.gz 3.62 KB 3.61 KB -10 bytes (0%)
page-dataset.js.gz 18.32 KB 18.3 KB -19 bytes (0%)
page-doc-publish-your-data.js.gz 3.73 KB 3.71 KB -18 bytes (0%)
page-doc.js.gz 1.88 KB 1.86 KB -16 bytes (1%)
page-events.js.gz 2.39 KB 2.35 KB -40 bytes (2%)
page-harvest.js.gz 2.98 KB 2.98 KB -3 bytes (0%)
page-index.js.gz 6.07 KB 6.07 KB -3 bytes (0%)
page-legal.js.gz 833 bytes 818 bytes -15 bytes (2%)
page-publication-datasets.js.gz 5.99 KB 5.97 KB -12 bytes (0%)
page-publication-organization.js.gz 9.31 KB 9.28 KB -29 bytes (0%)
page-publication-producers.js.gz 5.52 KB 5.47 KB -51 bytes (1%)
page-publication.js.gz 3.81 KB 3.8 KB -11 bytes (0%)
page-search.js.gz 7.69 KB 7.68 KB -10 bytes (0%)
page-doc-link-proxy.js.gz 1.47 KB 1.46 KB -13 bytes (1%)
page-embed-preview.js.gz 4.51 KB 4.51 KB 0 bytes (0%)
chunk-dataset_downloads_preview_table.js.gz 12.59 KB 12.59 KB -1 bytes (0%)
page-_app.js.gz 2.75 KB 2.77 KB 19 bytes (1%)
static-commons-main-[hash].js.gz 132.87 KB 133.18 KB 322 bytes (0%)
chunk-centered_map_map.js.gz 169.7 KB 169.7 KB 1 bytes (0%)

Update with-fetch HOC to take an array of promises.
Move attach-session to _app component.
@codecov-io
Copy link

codecov-io commented Aug 27, 2018

Codecov Report

Merging #715 into master will increase coverage by 0.33%.
The diff coverage is 10%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #715      +/-   ##
=========================================
+ Coverage    4.93%   5.27%   +0.33%     
=========================================
  Files         113     113              
  Lines        1500    1499       -1     
=========================================
+ Hits           74      79       +5     
+ Misses       1426    1420       -6
Impacted Files Coverage Δ
components/require-auth.js 0% <ø> (ø) ⬆️
components/hoc/with-fetch.js 0% <0%> (ø) ⬆️
components/hoc/attach-session.js 0% <0%> (ø) ⬆️
components/hoc/with-session.js 0% <0%> (ø) ⬆️
components/link.js 100% <100%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6deaf8f...6351531. Read the comment docs.

@tusbar tusbar temporarily deployed to geodatagouv-pr-715 August 27, 2018 11:16 Inactive
@tusbar tusbar requested a review from jdesboeufs August 27, 2018 11:20
Stop using old context API in case it disapears.
@tusbar tusbar temporarily deployed to geodatagouv-pr-715 August 27, 2018 11:45 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants