Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unmaintained underscore.string #721

Merged
merged 1 commit into from
Oct 2, 2018

Conversation

tusbar
Copy link
Contributor

@tusbar tusbar commented Sep 4, 2018

Use lodash.truncate for prune.

@tusbar tusbar added this to the 3.8.0 milestone Sep 4, 2018
@tusbar tusbar self-assigned this Sep 4, 2018
@jdesboeufs jdesboeufs temporarily deployed to geodatagouv-pr-721 September 4, 2018 10:39 Inactive
@buildsize
Copy link

buildsize bot commented Sep 4, 2018

File name Previous Size New Size Change
page-_error.js.gz 185 bytes 185 bytes 0 bytes (0%)
page-catalog.js.gz 56.49 KB 56.48 KB -14 bytes (0%)
page-catalogs.js.gz 3.55 KB 3.55 KB -1 bytes (0%)
page-dataset.js.gz 19.31 KB 19.22 KB -91 bytes (0%)
page-doc-publish-your-data.js.gz 3.7 KB 3.7 KB 0 bytes (0%)
page-doc.js.gz 1.91 KB 1.91 KB 0 bytes (0%)
page-events.js.gz 2.29 KB 2.29 KB 2 bytes (0%)
page-harvest.js.gz 3.05 KB 3.04 KB -1 bytes (0%)
page-index.js.gz 5.76 KB 5.76 KB 2 bytes (0%)
page-legal.js.gz 806 bytes 805 bytes -1 bytes (0%)
page-publication-datasets.js.gz 5.91 KB 5.91 KB -1 bytes (0%)
page-publication-organization.js.gz 10.35 KB 10.35 KB -3 bytes (0%)
page-publication-producers.js.gz 5.39 KB 5.38 KB -4 bytes (0%)
page-publication.js.gz 3.75 KB 3.75 KB -6 bytes (0%)
page-search.js.gz 7.76 KB 7.76 KB -3 bytes (0%)
page-doc-link-proxy.js.gz 1.44 KB 1.45 KB 2 bytes (0%)
page-embed-preview.js.gz 4.78 KB 4.73 KB -45 bytes (1%)
page-_app.js.gz 2.8 KB 2.8 KB -1 bytes (0%)
chunk-centered-map.[hash].js.gz 169.31 KB 169.31 KB -2 bytes (0%)
chunk-commons.[hash].js.gz 124.51 KB 125.4 KB 907 bytes (1%)
chunk-preview-table.[hash].js.gz 12.6 KB 12.6 KB -2 bytes (0%)
runtime-main-[hash].js.gz 1.68 KB 1.68 KB -3 bytes (0%)
runtime-webpack-[hash].js.gz 1.22 KB 1.22 KB -1 bytes (0%)

@codecov-io
Copy link

codecov-io commented Sep 4, 2018

Codecov Report

Merging #721 into master will increase coverage by 0.12%.
The diff coverage is 37.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #721      +/-   ##
=========================================
+ Coverage    5.23%   5.36%   +0.12%     
=========================================
  Files         113     114       +1     
  Lines        1508    1510       +2     
=========================================
+ Hits           79      81       +2     
  Misses       1429    1429
Impacted Files Coverage Δ
components/markdown-summary.js 0% <0%> (ø) ⬆️
components/meta.js 0% <0%> (ø) ⬆️
components/markdown-preview.js 0% <0%> (ø) ⬆️
lib/distribution.js 100% <100%> (ø) ⬆️
lib/string/prune.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a4ed97...4b41b49. Read the comment docs.

Use lodash.truncate for prune.
@tusbar tusbar force-pushed the tusbar/remove-underscore-string branch from 3219fb0 to 4b41b49 Compare October 2, 2018 13:08
@tusbar tusbar merged commit 5fab91f into master Oct 2, 2018
@tusbar tusbar deleted the tusbar/remove-underscore-string branch October 2, 2018 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants