Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major rewrite to use link-proxy and new geoplatform #746

Merged
merged 34 commits into from
Nov 29, 2018
Merged

Conversation

tusbar
Copy link
Contributor

@tusbar tusbar commented Sep 25, 2018

  • Switched to resources. They can either be services (WFS) or downloads from link-proxy.
  • Fixed publication
  • Fixed issues in discussions
  • Cleaned a lot of async code by removing some withFetch HOC wraps.
  • Add support for node 10

@tusbar tusbar self-assigned this Sep 25, 2018
@jdesboeufs jdesboeufs temporarily deployed to geodatagouv-pr-746 September 25, 2018 15:12 Inactive
@buildsize
Copy link

buildsize bot commented Sep 25, 2018

File name Previous Size New Size Change
page-_error.js.gz 186 bytes 186 bytes 0 bytes (0%)
page-catalog.js.gz 57.08 KB 57.16 KB 76 bytes (0%)
page-catalogs.js.gz 3.55 KB 3.55 KB 2 bytes (0%)
page-dataset.js.gz 18.06 KB 19.31 KB 1.25 KB (7%)
page-doc-publish-your-data.js.gz 3.7 KB 3.7 KB 0 bytes (0%)
page-doc.js.gz 1.91 KB 1.91 KB -3 bytes (0%)
page-events.js.gz 2.29 KB 2.31 KB 16 bytes (1%)
page-harvest.js.gz 3.05 KB 3.05 KB 0 bytes (0%)
page-index.js.gz 5.76 KB 5.78 KB 23 bytes (0%)
page-legal.js.gz 806 bytes 806 bytes 0 bytes (0%)
page-publication-datasets.js.gz 5.9 KB 6.02 KB 115 bytes (2%)
page-publication-organization.js.gz 9.17 KB 9.17 KB 5 bytes (0%)
page-publication-producers.js.gz 5.38 KB 5.4 KB 20 bytes (0%)
page-publication.js.gz 3.75 KB 3.76 KB 17 bytes (0%)
page-search.js.gz 7.76 KB 7.76 KB 0 bytes (0%)
page-doc-link-proxy.js.gz 1.44 KB 1.44 KB -1 bytes (0%)
page-embed-preview.js.gz 4.74 KB 4.57 KB -170 bytes (4%)
page-_app.js.gz 2.8 KB 2.8 KB -2 bytes (0%)
chunk-centered-map.[hash].js.gz 169.32 KB 169.32 KB 0 bytes (0%)
chunk-commons.[hash].js.gz 128.9 KB 129.09 KB 190 bytes (0%)
chunk-preview-table.[hash].js.gz 12.6 KB 12.6 KB 0 bytes (0%)
runtime-main-[hash].js.gz 396 bytes 394 bytes -2 bytes (1%)
runtime-webpack-[hash].js.gz 1.22 KB 1.22 KB 0 bytes (0%)

@tusbar tusbar temporarily deployed to geodatagouv-pr-746 September 25, 2018 16:10 Inactive
@tusbar tusbar temporarily deployed to geodatagouv-pr-746 September 25, 2018 16:31 Inactive
@tusbar tusbar temporarily deployed to geodatagouv-pr-746 September 25, 2018 17:46 Inactive
@tusbar tusbar temporarily deployed to geodatagouv-pr-746 September 25, 2018 17:46 Inactive
@tusbar tusbar temporarily deployed to geodatagouv-pr-746 September 25, 2018 18:42 Inactive
@tusbar tusbar temporarily deployed to geodatagouv-pr-746 September 25, 2018 18:48 Inactive
@tusbar tusbar temporarily deployed to geodatagouv-pr-746 September 25, 2018 22:45 Inactive
@codecov-io
Copy link

codecov-io commented Sep 25, 2018

Codecov Report

Merging #746 into master will decrease coverage by 1.02%.
The diff coverage is 0.64%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #746      +/-   ##
=========================================
- Coverage    5.36%   4.33%   -1.03%     
=========================================
  Files         114     117       +3     
  Lines        1510    1545      +35     
=========================================
- Hits           81      67      -14     
- Misses       1429    1478      +49
Impacted Files Coverage Δ
components/dataset/resources/preview-table.js 0% <ø> (ø)
components/centered-map/loader.js 0% <ø> (ø) ⬆️
components/dataset/discussions/form.js 0% <ø> (ø) ⬆️
components/catalog/statistics.js 0% <ø> (ø) ⬆️
components/dataset/discussions/list.js 0% <ø> (ø) ⬆️
components/page/header/index.js 0% <ø> (ø) ⬆️
components/button.js 0% <ø> (ø) ⬆️
components/search/result/index.js 0% <ø> (ø) ⬆️
components/contact.js 0% <ø> (ø) ⬆️
components/box.js 0% <ø> (ø) ⬆️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0deb3bb...bd73ddc. Read the comment docs.

@tusbar tusbar temporarily deployed to geodatagouv-pr-746 September 26, 2018 08:36 Inactive
@tusbar tusbar temporarily deployed to geodatagouv-pr-746 September 26, 2018 12:41 Inactive
@tusbar tusbar temporarily deployed to geodatagouv-pr-746 September 28, 2018 09:28 Inactive
@tusbar tusbar temporarily deployed to geodatagouv-pr-746 October 1, 2018 14:45 Inactive
@tusbar tusbar temporarily deployed to geodatagouv-pr-746 October 2, 2018 12:46 Inactive
@tusbar tusbar temporarily deployed to geodatagouv-pr-746 October 2, 2018 13:01 Inactive
@tusbar tusbar temporarily deployed to geodatagouv-pr-746 October 2, 2018 13:17 Inactive
@jdesboeufs jdesboeufs temporarily deployed to geodatagouv-pr-746 October 8, 2018 13:16 Inactive
@tusbar tusbar temporarily deployed to geodatagouv-pr-746 October 8, 2018 13:21 Inactive
@tusbar tusbar changed the title [WIP] Rewrite dataset downloads to use resources Rewrite dataset downloads to use resources Oct 8, 2018
@tusbar tusbar temporarily deployed to geodatagouv-pr-746 October 12, 2018 11:20 Inactive
@tusbar tusbar temporarily deployed to geodatagouv-pr-746 October 12, 2018 11:35 Inactive
@tusbar tusbar merged commit f004cf5 into master Nov 29, 2018
@tusbar tusbar deleted the tusbar/link-proxy branch November 29, 2018 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants