Do not unregister datasets with a 404'ed base schedule at time of startup #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Antoine D <antoine.desbordes@gmail.com>
|
For now, just a failing test to reproduce the issue has been added, to start playing around. |
antoine-de
reviewed
Jan 11, 2021
|
we can remove the draft mode no? I found a way to hide the |
This was referenced Jan 18, 2021
thbar
changed the title
|
@antoine-de sorry, I just understood now what you meant by removing the draft mode, thought you were referring to something in the code. I've moved out of draft mode, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen in #107, if at start time, a given resource is not available, it will be removed from the available resources forever.
In this PR, we instead implement a mechanism to ensure the initial failure has a chance to recover later.
It must be noted thought that it will currently take 24 hours before the dataset is retried (see #111), something we will improve in a separate PR.