-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix of the login form after Flask-Security and WTForms upgrade #224
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget the changelog ;)
I think the security override init may not work anymore. captcha_code
attribute is missing when trying to display http://dev.local:7000/fr/register
{{ f.label.text }} | ||
</label> | ||
</div> | ||
{{ render_boolean_field(f) }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you take this update from Flask Security forms?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no I made a func for it:
{% macro render_boolean_field(f) %}
<div class="fr-checkbox-group">
{{ f() }}
<label class="fr-label" for="{{ f.id }}">
{{ f.label.text }}
</label>
</div>
{% endmacro %}
I did this so i can reorganize the login form after the update
I still reproduce this issue.
Not sure why it seems to work in your case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we're clear! 👏
Don't forget the changelog!
Related to datagouv/data.gouv.fr#1053