-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add last update sort #242
Add last update sort #242
Conversation
@@ -21,8 +21,9 @@ | |||
{% set bundle = 'search' %} | |||
|
|||
{% set sorts = [ | |||
{"label": _('Newest'),"value": "created", "order": "desc"}, | |||
{"label": _('Recently created'),"value": "created", "order": "desc"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@agarrone, we're interested for your opinons on wording and order. We've modified Newest
to Recently created
and added Last updated
.
In french, it looks like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll say :
-
Pertinence
-
Date de mise à jour
-
Date de création
-
Nombre d'abonnés
-
Nombre de réutilisations
-
Relevance
-
New
-
Updated
-
Number of followers
-
Number of reuses
I don't think that we need both ascending and descending.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pick up on this a bit late, but Date de création
is not the translation of New
(same for Updated). Do we want to keep this asymmetry or do you prefer one or the other @agarrone?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the english wording from Kaggle.
I don't mind the asymmetry, english often allows less words to be understood :)
If you think it's better you can change for Creation date and Last update I guess.
fix datagouv/data.gouv.fr#1035