Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add last update sort #242

Merged
merged 10 commits into from
May 4, 2023
Merged

Add last update sort #242

merged 10 commits into from
May 4, 2023

Conversation

quaxsze
Copy link
Contributor

@quaxsze quaxsze commented Apr 25, 2023

@quaxsze quaxsze requested a review from maudetes April 25, 2023 15:18
@@ -21,8 +21,9 @@
{% set bundle = 'search' %}

{% set sorts = [
{"label": _('Newest'),"value": "created", "order": "desc"},
{"label": _('Recently created'),"value": "created", "order": "desc"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agarrone, we're interested for your opinons on wording and order. We've modified Newest to Recently created and added Last updated.
In french, it looks like
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll say :

  • Pertinence

  • Date de mise à jour

  • Date de création

  • Nombre d'abonnés

  • Nombre de réutilisations

  • Relevance

  • New

  • Updated

  • Number of followers

  • Number of reuses

I don't think that we need both ascending and descending.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pick up on this a bit late, but Date de création is not the translation of New (same for Updated). Do we want to keep this asymmetry or do you prefer one or the other @agarrone?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the english wording from Kaggle.
I don't mind the asymmetry, english often allows less words to be understood :)
If you think it's better you can change for Creation date and Last update I guess.

@quaxsze quaxsze merged commit 8c844a8 into master May 4, 2023
@quaxsze quaxsze deleted the issue1035 branch May 4, 2023 12:21
@maudetes maudetes mentioned this pull request May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Permettre de trier par date de mise à jour plutôt que date de publication
3 participants