Skip to content
This repository has been archived by the owner on Sep 14, 2021. It is now read-only.

New entrypoints #263

Merged
merged 4 commits into from Feb 12, 2018
Merged

New entrypoints #263

merged 4 commits into from Feb 12, 2018

Conversation

noirbizarre
Copy link
Contributor

This PR properly split plugins translations and theme translation (first step to using each others separately) and expose new entrypoints.

Connects to opendatateam/udata#1431

Copy link
Contributor

@abulte abulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have so many specific things regarding i18n handling in udata-gouvfr (vs udata)? Can't udata manage the translations from all its plugins, including udata-gouvfr?

@noirbizarre
Copy link
Contributor Author

This is because udata-gouvfr includes both plugins and a theme. In udata the theme is just an empty shell, so there is no translations to handle.

Some are using only the theme and in this is the case, there is no translations until this PR.

In addition to the split, I also added the same metadata addition already present in udata

Copy link
Contributor

@abulte abulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I got it completely but you can explain face to face tomorrow ;-)

@noirbizarre noirbizarre merged commit cfac38e into etalab:master Feb 12, 2018
@noirbizarre noirbizarre deleted the new-entrypoints branch February 12, 2018 11:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants