Skip to content

Commit

Permalink
Merge pull request #150 from marty1885/apichange
Browse files Browse the repository at this point in the history
Fix GCC build fail
  • Loading branch information
marty1885 committed Jun 29, 2020
2 parents db858e5 + 006744a commit 6b1549e
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Etaler/Core/Error.hpp
Expand Up @@ -14,7 +14,7 @@ namespace et

ETALER_EXPORT std::string genStackTrace(size_t skip = 0);

class ETLAER_EXPORT EtError : public std::exception
class EtError : public std::exception
{
public:
explicit EtError(const std::string &msg);
Expand Down
13 changes: 13 additions & 0 deletions docs/source/DeveloperNotes.md
Expand Up @@ -23,3 +23,16 @@ This file documents some facts about the codebase that might be useful for it's
* Nvidia's OpenCL implementation although very optimized, has piles upon piles of problems.
* Use POCL w/ CUDA backend for debugging. POCL is a lot slower, but very stable.
* Or use Intel/AMD's OpenCL SDK

## Programing style

* Use LF line ending, CRLF is evil
* Respect PyTorch/NumPy's naming
* Respect C++STL's naming
* Unless violating the 2 previous rules
* Variables use snake_case
* Functions use camalCase
* Types use PascalCase
* Macros are ALL_CAPS
* Unless the macro is intended to be used as a type or function. Then use the respective case
* Lambda functions/callable class instances use snake_case

0 comments on commit 6b1549e

Please sign in to comment.