Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New update broke android widget #1463

Closed
mahurinj opened this issue Oct 3, 2023 · 15 comments
Closed

New update broke android widget #1463

mahurinj opened this issue Oct 3, 2023 · 15 comments

Comments

@mahurinj
Copy link

mahurinj commented Oct 3, 2023

Just noticed that the calendar widget on Android is showing incorrect dates since the latest update 1.0.36. In the actual app they are displaying fine (which let me breath a sigh of relief) just the widget is off for some reason. It shows everything one day sooner than it actually is in the calendar.

@Gitsaibot
Copy link
Contributor

Gitsaibot commented Oct 4, 2023

@lmamane I think this may have to do with your changes. Can you have a look?

@mahurinj I can't reproduce. Which android version do you use? Does this happen with all events? Or only with e.g. all-day? The widget date is correct?

@Haisha10
Copy link

Haisha10 commented Oct 5, 2023

I also have this problem. The events are displayed one day earlier in the widget. The events are shown as if they happen a day before the scheduled one, no matter if it is for a few hours or the all-day.

In my case I have Android 9 with Etar 1.0.36.

@Gitsaibot
Copy link
Contributor

Does recreating the widget change anything? Under https://github.com/Etar-Group/Etar-Calendar/actions there is a debug apk for each commit. Would be helpful if you could test from which commit the widget no longer works.

e.g. https://github.com/Etar-Group/Etar-Calendar/actions/runs/6261596621

@Haisha10
Copy link

Haisha10 commented Oct 5, 2023

The commit you suggested seems to work fine. The events are displayed in their corresponding days.

@lmamane
Copy link

lmamane commented Oct 5, 2023

Can you have a look?

Glad to, but I need to reproduce. I can't. Anybody that has the problem / can reproduce:

  1. Was the event created in an older version of etar? Then it may have been stored incorrectly. Just editing the event (change its date/time to something else, save, edit again, change it back to correct value) in the latest/new version would then fix the problem.
  2. Please give exact reproduction instructions:
    1. exact date and time of the event, including timezone of the event
    2. what is the system-wide configured timezone?
    3. is "use home timezone" activated? What is the home timezone?

@Haisha10
Copy link

Haisha10 commented Oct 5, 2023

For example, I just created a new event (with the new version 1.0.36) for Saturday, October 7 from 9am to 2pm time zone GMT-5 (that's my local time zone). Inside the app it's displayed just fine but on the widget is shown as a day earlier (Friday, October 6 from 9am to 2pm).

@Gitsaibot
Copy link
Contributor

@lmamane I can now reproduce if I choose a "negativ" system-wide timezone like in USA.

@lmamane
Copy link

lmamane commented Oct 6, 2023

This is fixed in pull request #1469

@ghost
Copy link

ghost commented Nov 9, 2023

Since that PR has been merged, would greatly appreciate a new release being cut. :)

@realwuffi
Copy link

A new release would be awesome. Pretty anoying bug, especially when my wife asks when it willbe fixed :-)

@Gitsaibot
Copy link
Contributor

Fixed in Release 1.0.37

@ghost
Copy link

ghost commented Nov 16, 2023

Is there anything special that needs to happen to make Fdroid happy?

@jspricke
Copy link
Member

@wkeiuluf F-Droid normally picks up releases automatically but I just did so manually to make sure it is in the next build cycle. See here for how long it takes to be available: https://gitlab.com/fdroid/wiki/-/wikis/FAQ#how-long-does-it-take-for-my-app-to-show-up-on-website-and-client

@ghost
Copy link

ghost commented Nov 16, 2023

Understood, thanks for the link!

@realwuffi
Copy link

realwuffi commented Dec 16, 2023

One last question here:
The new version has still not been integrated into LOS20 and I can't update it because of some permission issues.
Anyone knows what needs to be done to get this fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants